Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd patch for handling DHCP router #6659

Merged
merged 2 commits into from
Feb 22, 2020

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Feb 16, 2020

"DHCP: No gateway received from DHCP server"

Fails systemd-networkd-wait-online.service

Closes #6655

Improves error message, but DHCP can still fail.
(it doesn't really like the response from VirtualBox)

eth1: DHCP: No gateway received from DHCP server.

Didn't succeed in backporting sysctl ipv6 check,
so disabling the (ipv6) link-local fallback (for now).

"DHCP: No gateway received from DHCP server"

Fails systemd-networkd-wait-online.service
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2020
@codecov-io
Copy link

Codecov Report

Merging #6659 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6659   +/-   ##
=======================================
  Coverage   38.56%   38.56%           
=======================================
  Files         142      142           
  Lines        8642     8642           
=======================================
  Hits         3333     3333           
  Misses       4893     4893           
  Partials      416      416

@afbjorklund afbjorklund changed the title WIP: Add systemd patch for handling DHCP router Add systemd patch for handling DHCP router Feb 16, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2020
@medyagh medyagh merged commit e8e1031 into kubernetes:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemd networkd configuration broken
4 participants