Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New addon: registry-aliases #6657

Merged
merged 3 commits into from
Mar 19, 2020
Merged

New addon: registry-aliases #6657

merged 3 commits into from
Mar 19, 2020

Conversation

kameshsampath
Copy link

@kameshsampath kameshsampath commented Feb 16, 2020 •
edited
Loading

  • Service Account and binding to run the job
  • Registry aliases ConfigMap
  • Registry aliases daemonset to update the node etc/hosts

fixes #6656

Signed-off-by: Kamesh Sampath ksampath@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 16, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @kameshsampath!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kameshsampath. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kameshsampath
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This was referenced Feb 16, 2020
Closed
Closed
@RA489
Copy link

RA489 commented Feb 19, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

tstromberg
tstromberg suggested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding a README into the addon folder describing the behavioral/environmental changes this addon introduces?

Thanks!

@tstromberg tstromberg changed the title (fix) Create addon to configure registry helper New addon: registry-aliases Feb 19, 2020
@medyagh
Copy link
Member

medyagh commented Feb 20, 2020

Do you mind putting some examples of using this ?

@kameshsampath
Copy link
Author

yes I can do that I have working example folder which users can refer to

@kameshsampath
Copy link
Author

@medyagh and @tstromberg - the PR is updated with README and usage. Please review and merge

We need to handle the reversal of things done by add-on, we shall take that as separate issue .

@minikube-pr-bot
Copy link

All Times minikube: [ 92.929873 92.385825 92.650600]
All Times Minikube (PR 6657): [ 90.921868 94.616252 94.975845]

Average Minikube (PR 6657): 93.504655
Average minikube: 92.655433

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6657) |
+----------------------+-----------+--------------------+
| minikube v           |  0.147763 |           0.197063 |
| Creating kvm2        | 20.225015 |          20.973315 |
| Preparing Kubernetes | 49.276671 |          50.045426 |
| Pulling images       |           |                    |
| Launching Kubernetes | 20.403348 |          20.306530 |
| Waiting for cluster  |  0.054069 |           0.069658 |
+----------------------+-----------+--------------------+

@kameshsampath
Copy link
Author

/ok-to-test

medyagh
medyagh requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Profile command does not create profile anymore, please update the docs.
(to start a profile, you can use start command)

deploy/addons/registry-aliases/README.md Outdated
### Start minikube

```shell
minikube profile demo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The profile command has been changed . It no longer creates a profile. Just use start -p demo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to the new format

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done thanks ! @medyagh ^^

Kamesh Sampath added 3 commits March 8, 2020 09:31
(fix) Create addon to configure registry helper
70ca2de 
- Service Account and binding to run the job
- Registry aliases ConfigMap
- Registry aliases daemonset to update the node etc/hosts

fixes: 4604

Signed-off-by: Kamesh Sampath <ksampath@redhat.com>
updated readme with usage instructions
28ffcb1 
Signed-off-by: Kamesh Sampath <ksampath@redhat.com>
(chore) fix README to use new profile format
db27b59
@minikube-pr-bot
Copy link

All Times minikube: [ 67.880970 60.074232 61.744346]
All Times Minikube (PR 6657): [ 94.054838 92.374125 93.666554]

Average Minikube (PR 6657): 93.365172
Average minikube: 63.233183

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6657) |
+----------------------+-----------+--------------------+
| minikube v           |  0.185397 |           0.124679 |
| Creating kvm2        | 39.146173 |          20.594608 |
| Preparing Kubernetes |  0.721178 |          49.184763 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.796392 |          21.436350 |
| Waiting for cluster  |  0.064733 |           0.397971 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 8d1f455 into kubernetes:master Mar 19, 2020
@tstromberg
Copy link
Contributor

Thank you!

@kameshsampath
Copy link
Author

kameshsampath commented Mar 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@tstromberg tstromberg tstromberg approved these changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addon to configure internal registry aliases
7 participants
@kameshsampath @k8s-ci-robot @minikube-bot @RA489 @minikube-pr-bot @medyagh @tstromberg