-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docker-env and add unit and integration tests #6604
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Do you mind adding a docker entry to |
Also, is there an integration test that runs |
/ok-to-test |
Lint failure:
|
All Times minikube: [ 95.833955 91.993915 93.698440] Average minikube: 93.842103 Averages Time Per Log
|
fixed lint |
All Times minikube: [ 94.454109 92.421270 91.599450] Average minikube: 92.824943 Averages Time Per Log
|
0746133
to
6d84493
Compare
Codecov Report
@@ Coverage Diff @@
## master #6604 +/- ##
=======================================
Coverage 37.51% 37.51%
=======================================
Files 138 138
Lines 8792 8792
=======================================
Hits 3298 3298
- Misses 5078 5080 +2
+ Partials 416 414 -2
|
All Times minikube: [ 92.883412 87.392601 90.922051] Average minikube: 90.399354 Averages Time Per Log
|
afb27c3
to
2404261
Compare
All Times minikube: [ 91.279304 94.006040 93.822893] Average minikube: 93.036079 Averages Time Per Log
|
Added both unit and integration tests for docker-env command.
test with both docker and kvm driver
Before this PR:
After this PR :
closes #6600
closes #6546