Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman driver #6515

Merged
merged 63 commits into from
Feb 13, 2020
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
24b1b99
Add initial podman
medyagh Feb 6, 2020
e8a7137
Add cgroup option for podman and remove resource limit for podman
medyagh Feb 6, 2020
f896450
typo
medyagh Feb 6, 2020
ac55bf7
add podman to linux supported too
medyagh Feb 6, 2020
ef19064
Add podman to IsKic
medyagh Feb 6, 2020
ca6f91a
remove cp -a for podman
medyagh Feb 6, 2020
843fec9
add network inspect for podman
medyagh Feb 6, 2020
2093545
string
medyagh Feb 6, 2020
780a395
podman cp fix
medyagh Feb 6, 2020
f88e96d
chmod podman fix
medyagh Feb 6, 2020
c946018
more comments
medyagh Feb 6, 2020
f57b924
struggling podman cp
medyagh Feb 6, 2020
a77e173
fix inspect ip for podman
medyagh Feb 6, 2020
6c3d07c
fix hard coded docker
medyagh Feb 6, 2020
293585b
refactor all hard-coded var lib path
medyagh Feb 7, 2020
2d49e23
remove white space from ip result
medyagh Feb 7, 2020
f5158a8
Make podman run with sudo
medyagh Feb 7, 2020
5578403
typo
medyagh Feb 7, 2020
1280ed8
warn that podman doesnt allow cpu memory
medyagh Feb 7, 2020
4dd5d16
fix link to correct upcoming docs
medyagh Feb 7, 2020
9187219
add helpers for container ips
medyagh Feb 7, 2020
745ef7e
More acurate error for too slow podman and docker
medyagh Feb 7, 2020
376bbe4
Organize constants file
medyagh Feb 7, 2020
34af2f5
lint
medyagh Feb 7, 2020
97c3584
add github action job for podman
medyagh Feb 7, 2020
a7de263
add podman jenkins script
medyagh Feb 7, 2020
347dfe9
update unit test data with new structure
medyagh Feb 7, 2020
e68aa7b
fix unit test
medyagh Feb 7, 2020
37fd7f4
try a different way to install podman
medyagh Feb 7, 2020
13c3384
try installing github actions podman with sudo
medyagh Feb 7, 2020
444e1c7
try one more time
medyagh Feb 7, 2020
de4a385
set pending for podman jenkins job
medyagh Feb 7, 2020
d5fbf6a
diferent way of installing gopogh
medyagh Feb 7, 2020
f145991
install golang using script for jobs
medyagh Feb 7, 2020
83e6831
dont fail on golang as not needed
medyagh Feb 7, 2020
7dfc144
check install golang +x
medyagh Feb 7, 2020
aae4790
try to fix goopogh installer
medyagh Feb 7, 2020
3710ac2
print podman version in integeration tests
medyagh Feb 7, 2020
80f77ba
resolve docker-env
medyagh Feb 7, 2020
b815ae3
spelling
medyagh Feb 7, 2020
48e0b25
revert back to var lib minikube
medyagh Feb 8, 2020
db30634
run with context timeout
medyagh Feb 8, 2020
ffece53
fix needs root to inlude poxman
medyagh Feb 8, 2020
7339605
fix integration test script for podman
medyagh Feb 8, 2020
aef1374
get rid of var volume
medyagh Feb 8, 2020
4b82ced
enable exec in var for podman
medyagh Feb 8, 2020
d20e66f
try not setting root kubeconif for podman script
medyagh Feb 8, 2020
ed7a636
adpot new configure for podman
medyagh Feb 8, 2020
a44e133
run podman tests non parallel
medyagh Feb 8, 2020
ecdf62d
change test run time for podman to containerd
medyagh Feb 8, 2020
acecdc6
remove sprintf from test files for clarity
medyagh Feb 10, 2020
5255fc7
installer in path based on git
medyagh Feb 10, 2020
d471ccf
delete left over file
medyagh Feb 10, 2020
1b44a8a
podman command runner
medyagh Feb 11, 2020
de19331
add noisy log only for podman
medyagh Feb 11, 2020
14cc32b
podman cp
medyagh Feb 11, 2020
e2aa6ff
lint
medyagh Feb 11, 2020
b30fbd3
podman cp
medyagh Feb 11, 2020
987858e
still fixing podman cp
medyagh Feb 11, 2020
5cfd32c
move kubeconfig up in test script to make it effective
medyagh Feb 11, 2020
3425d9d
correct host path vol for podman
medyagh Feb 12, 2020
fb29982
create dirs for volume car
medyagh Feb 12, 2020
4d227c7
resolve code review comments
medyagh Feb 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
create dirs for volume car
  • Loading branch information
medyagh committed Feb 12, 2020
commit fb29982e2351dc84fce3f46690920ff2425306ce
11 changes: 8 additions & 3 deletions pkg/drivers/kic/oci/oci.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,18 @@ func CreateContainerNode(p CreateParams) error {
"--label", fmt.Sprintf("%s=%s", nodeRoleKey, p.Role),
}

// volume path in minikube home folder to mount to /var
hostVarVolPath := filepath.Join(localpath.MiniPath(), "machines", p.Name, "var")
if err := os.MkdirAll(hostVarVolPath, 0777); err != nil {
medyagh marked this conversation as resolved.
Show resolved Hide resolved
return errors.Wrapf(err, "create var dir %s", hostVarVolPath)
}

if p.OCIBinary == Podman { // enable execing in /var
// podman mounts var/lib with no-exec by default https://github.com/containers/libpod/issues/5103
hostVolPath := filepath.Join(localpath.MiniPath(), "machines", p.Name)
runArgs = append(runArgs, "--volume", fmt.Sprintf("%s:/var:exec", hostVolPath))
runArgs = append(runArgs, "--volume", fmt.Sprintf("%s:/var:exec", hostVarVolPath))
}
if p.OCIBinary == Docker {
runArgs = append(runArgs, "--volume", "/var")
runArgs = append(runArgs, "--volume", fmt.Sprintf("%s:/var", hostVarVolPath))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we limit this so that it is only mounted this way on Linux? It potentially offers poor performance when a VM is involved.

// setting resource limit in privileged mode is only supported by docker
// podman error: "Error: invalid configuration, cannot set resources with rootless containers not using cgroups v2 unified mode"
runArgs = append(runArgs, fmt.Sprintf("--cpus=%s", p.CPUs), fmt.Sprintf("--memory=%s", p.Memory))
medyagh marked this conversation as resolved.
Show resolved Hide resolved
Expand Down