-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
status: Explicitly state that the cluster does not exist #6438
Conversation
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #6438 +/- ##
==========================================
- Coverage 37.68% 37.64% -0.04%
==========================================
Files 128 128
Lines 8654 8662 +8
==========================================
Hits 3261 3261
- Misses 4970 4978 +8
Partials 423 423
|
All Times minikube: [ 92.984026 98.199648 95.280520] Average minikube: 95.488065 Averages Time Per Log
|
is the line printed to stderr going to break stuff ingesting the json output? |
It could: but that's fine with me: stderr is never designed to be parsed, as it may always contain a random unrelated error message. |
While debugging a local integration test failure that said the cluster status was "", I dug in and noticed that "minikube status" on a nonexistent cluster emits no error:
This PR changes the behavior to emit an error to stderr, and populate the fields with "Nonexistent":
With
-o json
, it emits: