Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Improve minikube tunnel output #6365

Closed
wants to merge 1 commit into from
Closed

Conversation

RA489
Copy link

@RA489 RA489 commented Jan 22, 2020

Improve minikube tunnel output
fixes #6309

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pr. Could you please put the output in the pr description before and after this pr ?

@RA489
Copy link
Author

RA489 commented Jan 23, 2020

@medyagh Before output was following:

Status:
		machine: minikube
		pid: 22890
		route: 10.96.0.0/12 -> 10.0.7.230
		minikube: Running
		services: []
	    errors:
			minikube: no errors
			router: no errors
			loadbalancer emulator: no errors

@RA489
Copy link
Author

RA489 commented Jan 23, 2020

After this PR output was following:

Status:
		machine: minikube
		pid: 22890
		route: 10.96.0.0/12 -> 10.0.7.230
		minikube: Running
		services: []
	    errors:
			minikube: no errors
			router: no errors
			loadbalancer emulator: Get https://10.0.7.230:8443/api/v1/services: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

@tstromberg
Copy link
Contributor

We have some change-detector unit tests that you will need to update before we can merge this PR. Please run make test and take a look.

@medyagh medyagh changed the title Improve minikube tunnel output wip: Improve minikube tunnel output Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2020
@medyagh
Copy link
Member

medyagh commented Jan 31, 2020

@RA489 the output should not show any errors if there is no errors. this PR needs more work I will mark this as WIP

@RA489
Copy link
Author

RA489 commented Jan 31, 2020

@medyagh Currently in this PR if there is no error in all three like below it will skip printing below output.

errors:
			minikube: no errors
			router: no errors
			loadbalancer emulator: no error

@RA489
Copy link
Author

RA489 commented Feb 5, 2020

@RA489 the output should not show any errors if there is no errors. this PR needs more work I will mark this as WIP

It is currently not printing anything if minikube: no errors router: no errors loadbalancer emulator: no error in all three.

Do you want me to show some msg instead?

@sharifelgamal
Copy link
Collaborator

@RA489 You should just suppress the errors portion of the output if there are no errors.

@medyagh medyagh closed this Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve minikube tunnel output
5 participants