-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Improve minikube tunnel output #6365
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RA489 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pr. Could you please put the output in the pr description before and after this pr ?
@medyagh Before output was following:
|
After this PR output was following:
|
We have some change-detector unit tests that you will need to update before we can merge this PR. Please run |
@RA489 the output should not show any errors if there is no errors. this PR needs more work I will mark this as WIP |
@medyagh Currently in this PR if there is no error in all three like below it will skip printing below output.
|
It is currently not printing anything if Do you want me to show some msg instead? |
@RA489 You should just suppress the |
Improve minikube tunnel output
fixes #6309