Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem: Refresh advice, flip hide vs show default for links #6128

Merged
merged 2 commits into from
Dec 20, 2019
Merged

problem: Refresh advice, flip hide vs show default for links #6128

merged 2 commits into from
Dec 20, 2019

Conversation

tstromberg
Copy link
Contributor

  • If a match is found, we now hide the "open issue" link by default to avoid additional support for issues with known workarounds.
  • Allow matches to specify multiple operating systems
  • Prefer operating-system matches
  • Update problem set with more recent support requests

This addresses the following support requests: #6104 #5836 #6087 #5714 #5532 #5484 #4913 #5950 #5836 #3989 #6079 #5636 #6087 #6098 #6107 #6109 #4277

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2019
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 20, 2019
medyagh
medyagh approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@tstromberg
Copy link
Contributor Author

/ok-to-test

@minikube-bot
Copy link
Collaborator

Error: running mkcmp: exit status 1

@tstromberg tstromberg merged commit bb20281 into kubernetes:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tstromberg @k8s-ci-robot @minikube-bot @medyagh