Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error text to encourage better issue reports #6121

Merged
merged 3 commits into from
Dec 20, 2019

Conversation

tstromberg
Copy link
Contributor

This sounds less catastrophic.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2019
@tstromberg tstromberg changed the title Attempt to change error exit text to encourage better issue reports Change error text to encourage better issue reports Dec 19, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #6121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6121   +/-   ##
=======================================
  Coverage   36.68%   36.68%           
=======================================
  Files         113      113           
  Lines        8360     8360           
=======================================
  Hits         3067     3067           
  Misses       4892     4892           
  Partials      401      401

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 19, 2019
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 124.345436 125.324573 111.146279]
All Times Minikube (PR 6121): [ 124.606199 122.142400 123.974323]

Average minikube: 120.272096
Average Minikube (PR 6121): 123.574307

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6121) |
+----------------------+-----------+--------------------+
| minikube v           |  0.249767 |           0.249413 |
| Creating kvm2        | 46.790845 |          46.744808 |
| Preparing Kubernetes | 47.775921 |          51.330547 |
| Pulling images       |  2.718018 |           2.641010 |
| Launching Kubernetes | 20.128808 |          20.005002 |
| Waiting for cluster  |  2.562157 |           2.557992 |
+----------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 122.723092 125.061308 108.911473]
All Times Minikube (PR 6121): [ 124.754156 122.459180 122.940879]

Average minikube: 118.898624
Average Minikube (PR 6121): 123.384739

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6121) |
+----------------------+-----------+--------------------+
| minikube v           |  0.320449 |           0.317825 |
| Creating kvm2        | 45.493522 |          46.199230 |
| Preparing Kubernetes | 47.936147 |          50.721990 |
| Pulling images       |  2.751665 |           2.832504 |
| Launching Kubernetes | 19.449902 |          20.357725 |
| Waiting for cluster  |  2.902185 |           2.911617 |
+----------------------+-----------+--------------------+

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think this just needs to be rebased for travis to pass

@tstromberg tstromberg merged commit 00c2ba1 into kubernetes:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants