Fix profile list for non existenting folder #5955

cheeseandcereal · 2019-11-20T22:08:15Z

Behavior of minikube profile list -o json was dependent whether or not the $MINIKUBE_HOME/profiles folder exists or not.

This small update simply checks if the error is due to the folder not existing, and if so, simply returns the normal empty array results with a normal exit code

Before:

$ ls ~/.minikube/profiles
ls: cannot access '/home/adam/.minikube/profiles': No such file or directory
$ minikube profile list -o json
{"error":{"Op":"open","Path":"/root/.minikube/profiles","Err":2}}
$ echo $?
1
$ mkdir ~/.minikube/profiles
$ minikube profile list -o json
{"invalid":[],"valid":[]}
$ echo $?
0

After:

$ ls ~/.minikube/profiles
ls: cannot access '/home/adam/.minikube/profiles': No such file or directory
$ minikube profile list -o json
{"invalid":[],"valid":[]}
$ echo $?
0
$ mkdir ~/.minikube/profiles
$ minikube profile list -o json
{"invalid":[],"valid":[]}
$ echo $?
0

Signed-off-by: Adam Crowder <adam@adamcrowder.net>

k8s-ci-robot · 2019-11-20T22:08:17Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

minikube-bot · 2019-11-20T22:08:21Z

Can one of the admins verify this patch?

k8s-ci-robot · 2019-11-20T22:08:22Z

Welcome @cheeseandcereal!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-11-20T22:08:23Z

Hi @cheeseandcereal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-20T22:08:27Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cheeseandcereal
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cheeseandcereal · 2019-11-20T22:13:49Z

/assign @medyagh

codecov-io · 2019-11-20T22:14:46Z

Codecov Report

Merging #5955 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #5955   +/-   ##
=======================================
  Coverage   36.09%   36.09%           
=======================================
  Files         110      110           
  Lines        8208     8208           
=======================================
  Hits         2963     2963           
  Misses       4854     4854           
  Partials      391      391

Impacted Files	Coverage Δ
cmd/minikube/cmd/config/profile_list.go	`5.26% <0%> (ø)`	⬆️

cheeseandcereal · 2019-11-20T22:23:22Z

Also I signed the CLA before submitting, not sure why it's showing up as not signed. My git and github email are both the same as what's in the linux foundation account

medyagh · 2019-11-22T01:17:45Z

/check-cla

medyagh · 2019-11-22T01:18:15Z

@cheeseandcereal thanks for this PR, do you mind sharing the output Before and After this PR ?

cheeseandcereal · 2019-11-22T01:18:43Z

@cheeseandcereal thanks for this PR, do you mind sharing the output Before and After this PR ?

It's in the PR description

medyagh · 2019-11-22T01:24:15Z

@cheeseandcereal yes please

medyagh · 2019-11-22T01:26:04Z

/ok-to-test

RA489 · 2019-11-22T08:48:05Z

/check-cla

medyagh · 2019-11-25T21:20:47Z

@cheeseandcereal do you mind contacting the support or try again to make sure the CLA is signed ?

here is the link https://identity.linuxfoundation.org/?destination=node/285/individual-signup

once CLA is signed it would be good to merge

cheeseandcereal · 2019-11-25T21:36:08Z

/check-cla

cheeseandcereal · 2019-11-25T21:37:47Z

@medyagh Should be good now

medyagh · 2019-11-25T22:58:55Z

Thank you for this improvement this will make minikube looks better

This was reported in kubernetes#5898 and fixed in kubernetes#5955 in 2019. However the fix assumed that `listProfiles()` can return `config.ErrNotExists` while it returns `os.ErrNotExist` from `os.ReadDir`. Fixes kubernetes#15593

This was reported in [1] and fixed in [2] in 2019. However the fix assumed that `listProfiles()` can return `config.ErrNotExists` while it returns `os.ErrNotExist` from `os.ReadDir`. [1] kubernetes#5898 [2] kubernetes#5955

This was reported in [1] and fixed in [2] in 2019, but later it was broken by [3] in commit c3aafae. `listProfiles()` can return `os.ErrNotExist` from `os.ReadDir()` so it must be tested with `os.IsNotExist()`. [1] kubernetes#5898 [2] kubernetes#5955 [3] kubernetes#6440

fix profile list json command output

f8a2d1d

Signed-off-by: Adam Crowder <adam@adamcrowder.net>

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 20, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 20, 2019

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2019

k8s-ci-robot requested review from afbjorklund and priyawadhwa November 20, 2019 22:08

k8s-ci-robot assigned medyagh Nov 20, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 25, 2019

medyagh approved these changes Nov 25, 2019

View reviewed changes

medyagh merged commit 72e9730 into kubernetes:master Nov 25, 2019

medyagh changed the title ~~Fix profile list json command output~~ Fix profile list json when folder doesn't exist Nov 25, 2019

medyagh changed the title ~~Fix profile list json when folder doesn't exist~~ Fix profile list for non existenting folder Nov 25, 2019

nirs mentioned this pull request Jan 4, 2023

minikube profile list --output json fails with ENONT after fresh install #15593

Closed

nirs mentioned this pull request Jan 4, 2023

Fix profile list when profiles directory is missing #15594

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix profile list for non existenting folder #5955

Fix profile list for non existenting folder #5955

cheeseandcereal commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

minikube-bot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

cheeseandcereal commented Nov 20, 2019

codecov-io commented Nov 20, 2019

cheeseandcereal commented Nov 20, 2019

medyagh commented Nov 22, 2019

medyagh commented Nov 22, 2019

cheeseandcereal commented Nov 22, 2019 •

edited

Loading

medyagh commented Nov 22, 2019

medyagh commented Nov 22, 2019

RA489 commented Nov 22, 2019

medyagh commented Nov 25, 2019 •

edited

Loading

cheeseandcereal commented Nov 25, 2019

cheeseandcereal commented Nov 25, 2019

medyagh commented Nov 25, 2019

Fix profile list for non existenting folder #5955

Fix profile list for non existenting folder #5955

Conversation

cheeseandcereal commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

minikube-bot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

k8s-ci-robot commented Nov 20, 2019

cheeseandcereal commented Nov 20, 2019

codecov-io commented Nov 20, 2019

Codecov Report

cheeseandcereal commented Nov 20, 2019

medyagh commented Nov 22, 2019

medyagh commented Nov 22, 2019

cheeseandcereal commented Nov 22, 2019 • edited Loading

medyagh commented Nov 22, 2019

medyagh commented Nov 22, 2019

RA489 commented Nov 22, 2019

medyagh commented Nov 25, 2019 • edited Loading

cheeseandcereal commented Nov 25, 2019

cheeseandcereal commented Nov 25, 2019

medyagh commented Nov 25, 2019

cheeseandcereal commented Nov 22, 2019 •

edited

Loading

medyagh commented Nov 25, 2019 •

edited

Loading