Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-cache the latest kube-addon-manager #5935

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

tstromberg
Copy link
Contributor

To match what is deployed in deploy/addons/addon-manager.yaml.tmpl.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 17, 2019
@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #5935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5935   +/-   ##
=======================================
  Coverage   36.29%   36.29%           
=======================================
  Files         110      110           
  Lines        8235     8235           
=======================================
  Hits         2989     2989           
  Misses       4848     4848           
  Partials      398      398

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 20, 2019
@minikube-bot
Copy link
Collaborator

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Nov 25, 2019

@tstromberg needs rebase

@medyagh
Copy link
Member

medyagh commented Nov 25, 2019

/retest this please

@tstromberg
Copy link
Contributor Author

/ok-to-test

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 148.567292 145.956452 149.584447]
All Times Minikube (PR 5935): [ 142.742833 144.902620 140.865927]

Average minikube: 148.036064
Average Minikube (PR 5935): 142.837127

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5935) |
+----------------------+-----------+--------------------+
| minikube v           |  0.362859 |           0.361748 |
| Creating kvm2        | 51.423559 |          42.791908 |
| Preparing Kubernetes | 52.902757 |          54.139787 |
| Pulling images       | 18.558955 |          16.260778 |
| Launching Kubernetes | 21.961797 |          20.303851 |
| Waiting for cluster  |  2.771782 |           8.924599 |
+----------------------+-----------+--------------------+

@minikube-bot
Copy link
Collaborator

All Times minikube: [ 147.777107 139.049842 146.322582]
All Times Minikube (PR 5935): [ 141.549141 142.745650 143.967730]

Average minikube: 144.383177
Average Minikube (PR 5935): 142.754174

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5935) |
+----------------------+-----------+--------------------+
| minikube v           |  0.347321 |           0.345550 |
| Creating kvm2        | 48.410117 |          48.521075 |
| Preparing Kubernetes | 54.951897 |          52.800719 |
| Pulling images       | 17.427691 |          18.326022 |
| Launching Kubernetes | 20.638781 |          20.132707 |
| Waiting for cluster  |  2.557048 |           2.579048 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 1592eef into kubernetes:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants