Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noisy warning message while apiserver is booting up #5918

Merged
merged 1 commit into from
Nov 15, 2019

Conversation

tstromberg
Copy link
Contributor

#5894 added too much log spam. This message was being emitted every 500ms until the apiserver came up.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2019
@codecov-io
Copy link

Codecov Report

Merging #5918 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5918      +/-   ##
==========================================
+ Coverage    36.1%   36.11%   +<.01%     
==========================================
  Files         110      110              
  Lines        8206     8205       -1     
==========================================
  Hits         2963     2963              
+ Misses       4852     4851       -1     
  Partials      391      391
Impacted Files Coverage Δ
pkg/minikube/bootstrapper/kubeadm/kubeadm.go 18.88% <ø> (+0.04%) ⬆️

@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 15, 2019
@minikube-bot
Copy link
Collaborator

All Times minikube: [ 119.445411 121.416416 119.457576]
All Times Minikube (PR 5918): [ 122.706777 123.714578 122.467803]

Average Minikube (PR 5918): 122.963053
Average minikube: 120.106468

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 5918) |
+----------------------+-----------+--------------------+
| minikube v           |  0.298530 |           0.306126 |
| Creating kvm2        | 38.108156 |          38.473817 |
| Preparing Kubernetes | 52.055055 |          53.303525 |
| Pulling images       |  3.359987 |           2.863509 |
| Launching Kubernetes | 19.012807 |          19.896792 |
| Waiting for cluster  |  7.229145 |           8.077634 |
+----------------------+-----------+--------------------+

@tstromberg tstromberg merged commit 6faa8fc into kubernetes:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants