Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

none driver: Warn about --cpus, --memory, and --container-runtime settings #5845

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

tstromberg
Copy link
Contributor

Example command:

sudo ./out/minikube start --vm-driver=none --cpus 8 --memory 4096M --container-runtime=crio

Example output:

😄  minikube v1.5.2 on Debian rodete
⚠️  The 'none' driver does not respect the --cpus flag
⚠️  The 'none' driver does not respect the --memory flag
⚠️  Using the 'crio' runtime with the 'none' driver is an untested configuration!
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #5845 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5845      +/-   ##
=========================================
- Coverage   36.53%   36.5%   -0.04%     
=========================================
  Files         110     110              
  Lines        8116    8123       +7     
=========================================
  Hits         2965    2965              
- Misses       4762    4769       +7     
  Partials      389     389
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 19.79% <0%> (-0.21%) ⬇️

@medyagh
Copy link
Member

medyagh commented Nov 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 6, 2019
@minikube-bot
Copy link
Collaborator

Old binary: [195.607105739 182.042402986 187.611411986]
New binary: [172.762031762 174.174964124 182.997651902]
Average Old: 188.420307
Average New: 176.644883

@tstromberg tstromberg merged commit 79fcf71 into kubernetes:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants