Add helm-tiller addon #5363

woodcockjosh · 2019-09-16T00:43:52Z

This addon will add the tiller resources to the cluster so that helm init doesn't have to be ran every time a new minikube instance is created. This plugin is only necessary while helm is using tiller.

k8s-ci-robot · 2019-09-16T00:44:00Z

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-bot · 2019-09-16T00:44:02Z

Can one of the admins verify this patch?

woodcockjosh · 2019-09-16T00:50:42Z

#5302

TravisBuddy · 2019-09-16T00:59:49Z

Travis tests have failed

Hey @woodcockjosh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN=/home/travis/gopath/bin go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.12.9.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.0/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
./test.sh
= go mod ================================================================
ok
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.17.1'
golangci/golangci-lint info found version: 1.17.1 for v1.17.1/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/minikube/assets/addons.go:349: File is not `goimports`-ed (goimports)
		}, false, "helm"),
Makefile:334: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= boilerplate ===========================================================
ok
= schema_check ==========================================================
ok
= go test ===============================================================
ok  	k8s.io/minikube/cmd/minikube/cmd	0.088s	coverage: 16.2% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.072s	coverage: 18.7% of statements
ok  	k8s.io/minikube/pkg/drivers	0.027s	coverage: 18.4% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.071s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/assets	0.054s	coverage: 62.9% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	2.836s	coverage: 73.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/kubeadm	0.065s	coverage: 30.6% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.513s	coverage: 53.0% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.023s	coverage: 76.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.014s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.009s	coverage: 56.7% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.061s	coverage: 75.9% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.038s	coverage: 1.4% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	0.039s	coverage: 11.3% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.045s	coverage: 78.6% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.009s	coverage: 70.3% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.030s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.015s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.014s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.057s	coverage: 35.9% of statements
ok  	k8s.io/minikube/pkg/minikube/sshutil	0.447s	coverage: 75.0% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 8.4% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	2.108s	coverage: 64.5% of statements
ok  	k8s.io/minikube/pkg/util	0.963s	coverage: 62.0% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.015s	coverage: 59.1% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.002s	coverage: 0.0% of statements
ok
Makefile:232: recipe for target 'test' failed
make: *** [test] Error 4

TravisBuddy Request Identifier: 462a2890-d81d-11e9-94f2-eb1f1b783936

woodcockjosh · 2019-09-16T01:10:04Z

/retest

k8s-ci-robot · 2019-09-16T01:10:17Z

@woodcockjosh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

afbjorklund · 2019-09-16T05:54:51Z

/ok-to-test

woodcockjosh · 2019-09-16T10:17:18Z

/retest

deploy/addons/helm/helm-dp.tmpl

medyagh · 2019-09-16T11:01:48Z

this is an exciting PR !

medyagh · 2019-09-16T11:41:19Z

/retest this please

woodcockjosh · 2019-09-16T13:33:21Z

@medyagh should we add an entry to addons.md as part of this PR?

medyagh · 2019-09-16T15:30:50Z

@woodcockjosh yes please that's a good idea

woodcockjosh · 2019-09-17T14:15:36Z

@woodcockjosh yes please that's a good idea

This is done. Let me know if there's anything else needed to merge.

woodcockjosh · 2019-09-18T11:58:09Z

@medyagh I'm not sure why those crosscheck build tests failed. I rebased off master. Maybe that will fix it. I saw some message about failed to run Kubelet: unable to load bootstrap kubeconfig: stat /etc/kubernetes/bootstrap-kubelet.conf

tstromberg · 2019-09-20T22:28:02Z

/lgtm /approve

k8s-ci-robot · 2019-09-20T22:28:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg, woodcockjosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tstromberg · 2019-09-20T23:15:20Z

Question: should this be named helm-tiller, to thwart confusion with the upcoming helm3 release?

woodcockjosh · 2019-09-21T01:36:27Z

@tstromberg I'll leave that up to you

tstromberg · 2019-09-23T18:06:32Z

If you don't mind, let's name this "helm-tiller", so that it doesn't become confusing as to which part of helm it includes, particularly when helm v3.0 is released.

tstromberg · 2019-09-24T13:37:24Z

Thank you! This will be very useful for users.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2019

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 16, 2019

k8s-ci-robot requested review from afbjorklund and sharifelgamal September 16, 2019 00:44

woodcockjosh mentioned this pull request Sep 16, 2019

Auto install helm #5302

Closed

woodcockjosh force-pushed the add-helm-addon branch from 0f181e9 to 18fee0d Compare September 16, 2019 01:09

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2019

medyagh reviewed Sep 16, 2019

View reviewed changes

deploy/addons/helm/helm-dp.tmpl Outdated Show resolved Hide resolved

woodcockjosh force-pushed the add-helm-addon branch from 18fee0d to 8f42ca7 Compare September 16, 2019 13:22

woodcockjosh force-pushed the add-helm-addon branch from 8f42ca7 to c0a2869 Compare September 17, 2019 14:14

Add helm addon

d81e8e9

woodcockjosh force-pushed the add-helm-addon branch from c0a2869 to d81e8e9 Compare September 18, 2019 11:56

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2019

woodcockjosh mentioned this pull request Sep 22, 2019

Kubernetes v1.16.x (default in minikube v1.4) breaks Helm Tiller (v2.14.3) #5429

Closed

Rename helm addon to helm-tiller

dba30af

tstromberg changed the title ~~Add helm addon~~ Add helm-tiller addon Sep 24, 2019

tstromberg merged commit b75d4ab into kubernetes:master Sep 24, 2019

woodcockjosh deleted the add-helm-addon branch September 24, 2019 13:44

afbjorklund mentioned this pull request Dec 31, 2019

Suggestion: Remove helm-tiller from addons list #6187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add helm-tiller addon #5363

Add helm-tiller addon #5363

woodcockjosh commented Sep 16, 2019

k8s-ci-robot commented Sep 16, 2019

minikube-bot commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

TravisBuddy commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

k8s-ci-robot commented Sep 16, 2019

afbjorklund commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

medyagh commented Sep 16, 2019

medyagh commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

medyagh commented Sep 16, 2019

woodcockjosh commented Sep 17, 2019

woodcockjosh commented Sep 18, 2019 •

edited

Loading

tstromberg commented Sep 20, 2019

k8s-ci-robot commented Sep 20, 2019

tstromberg commented Sep 20, 2019 •

edited

Loading

woodcockjosh commented Sep 21, 2019

tstromberg commented Sep 23, 2019

tstromberg commented Sep 24, 2019

Add helm-tiller addon #5363

Add helm-tiller addon #5363

Conversation

woodcockjosh commented Sep 16, 2019

k8s-ci-robot commented Sep 16, 2019

minikube-bot commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

TravisBuddy commented Sep 16, 2019

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 462a2890-d81d-11e9-94f2-eb1f1b783936

woodcockjosh commented Sep 16, 2019

k8s-ci-robot commented Sep 16, 2019

afbjorklund commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

medyagh commented Sep 16, 2019

medyagh commented Sep 16, 2019

woodcockjosh commented Sep 16, 2019

medyagh commented Sep 16, 2019

woodcockjosh commented Sep 17, 2019

woodcockjosh commented Sep 18, 2019 • edited Loading

tstromberg commented Sep 20, 2019

k8s-ci-robot commented Sep 20, 2019

tstromberg commented Sep 20, 2019 • edited Loading

woodcockjosh commented Sep 21, 2019

tstromberg commented Sep 23, 2019

tstromberg commented Sep 24, 2019

woodcockjosh commented Sep 18, 2019 •

edited

Loading

tstromberg commented Sep 20, 2019 •

edited

Loading