Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uninstallation procedures for minikube #5119

Merged

Conversation

blueelvis
Copy link
Contributor

@blueelvis blueelvis commented Aug 17, 2019

Fixes #3372

Could someone do a quick review for MacOS and Linux? I have added the instructions to the best of my knowledge.

Feel free to suggest any edits.

EDIT - I just checked the deploy preview and I am not able to find the page. Any idea what I did wrong?

-Pranav

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @blueelvis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blueelvis
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2019
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for fixing it !
only needs to move the docs to each platform like the way the Install doc is

@@ -0,0 +1,72 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that it isn't in the preview - if I run make site locally from this PR, the page shows up.

FWIW, I'm fine with this doc being in the reference section. I don't think this document is likely to be consulted often, but the folks who are looking for it are likely to be desperate for it.

I'm also not going to be terribly particular about what it looks like in this first iteration. I'm just appreciative that it's being done =)

## Binary/Direct
If you have installed minikube using the direct download method, follow the below steps to uninstall minikube completely from your system -
- In the shell, type in `minikube delete` to delete the minikube cluster.
- Remove the binary using `rm /usr/local/bin/minikube`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use sudo: sudo rm /usr/local/bin/minikube

$ LANG=C rm /usr/local/bin/minikube 
rm: cannot remove '/usr/local/bin/minikube': Permission denied

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's use sudo here, since in many cases, the regular user won't have access.

Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use sudo on Linux, both for installation and for removal.
(when installing in system directories like this, not for using $HOME)

Not sure about on Mac, since brew tends to mess up permissions...
(at least earlier versions would run chown/chgrp/chmod on /usr/local)

@RA489
Copy link

RA489 commented Aug 19, 2019

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

tstromberg commented Aug 22, 2019

Thanks for doing this! Please let me know if there is anything I can help with.

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! FWIW, I feel that the file should just be named uninstall.md. The minikube part is implicit.

@@ -0,0 +1,72 @@
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd that it isn't in the preview - if I run make site locally from this PR, the page shows up.

FWIW, I'm fine with this doc being in the reference section. I don't think this document is likely to be consulted often, but the folks who are looking for it are likely to be desperate for it.

I'm also not going to be terribly particular about what it looks like in this first iteration. I'm just appreciative that it's being done =)

## Binary/Direct
If you have installed minikube using the direct download method, follow the below steps to uninstall minikube completely from your system -
- In the shell, type in `minikube delete` to delete the minikube cluster.
- Remove the binary using `rm /usr/local/bin/minikube`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's use sudo here, since in many cases, the regular user won't have access.


## Chocolatey
If you have installed minikube using Chocolatey package manager, follow the below steps to completely uninstall minikube from your system -
- Open a command prompt with Administrator privileges.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these asterisks bullets with no leading whitespace:

* Open a command...

# Uninstall minikube on Windows
Following are the ways you can install minikube on Windows. Depending on how you installed minikube, please follow the guide appropriately.

## Chocolatey
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't consider it neceserray, but if you want to get fancy, you can use the tabs widget that we use in the start docs:

{{% tabs %}}
{{% tab "Direct" %}}

Download and install minikube to /usr/local/bin:

```shell
 curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 \
   && sudo install minikube-linux-amd64 /usr/local/bin/minikube

{{% /tab %}}
{{% tab "Debian/Ubuntu (deb)" %}}


I understand that you may be flying in the dark due to hugo panic'ing on Windows with our site. 

@tstromberg tstromberg merged commit ec27e3a into kubernetes:master Sep 4, 2019
@tstromberg
Copy link
Contributor

Merging as a clear start is better than nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document uninstall procedures
6 participants