-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added uninstallation procedures for minikube #5119
Added uninstallation procedures for minikube #5119
Conversation
Hi @blueelvis. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: blueelvis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for fixing it !
only needs to move the docs to each platform like the way the Install doc is
@@ -0,0 +1,72 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find it in the doc preview
https://deploy-preview-5119--kubernetes-sigs-minikube.netlify.com/docs/reference/
how about adding the uninstal doc under each page separate, under where ppl look for install.
like here
https://deploy-preview-5119--kubernetes-sigs-minikube.netlify.com/docs/start/windows/
and
https://deploy-preview-5119--kubernetes-sigs-minikube.netlify.com/docs/start/macos/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that it isn't in the preview - if I run make site
locally from this PR, the page shows up.
FWIW, I'm fine with this doc being in the reference section. I don't think this document is likely to be consulted often, but the folks who are looking for it are likely to be desperate for it.
I'm also not going to be terribly particular about what it looks like in this first iteration. I'm just appreciative that it's being done =)
## Binary/Direct | ||
If you have installed minikube using the direct download method, follow the below steps to uninstall minikube completely from your system - | ||
- In the shell, type in `minikube delete` to delete the minikube cluster. | ||
- Remove the binary using `rm /usr/local/bin/minikube` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use sudo
: sudo rm /usr/local/bin/minikube
$ LANG=C rm /usr/local/bin/minikube
rm: cannot remove '/usr/local/bin/minikube': Permission denied
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Let's use sudo here, since in many cases, the regular user won't have access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use sudo
on Linux, both for installation and for removal.
(when installing in system directories like this, not for using $HOME)
Not sure about on Mac, since brew
tends to mess up permissions...
(at least earlier versions would run chown/chgrp/chmod on /usr/local
)
@minikube-bot OK to test |
Thanks for doing this! Please let me know if there is anything I can help with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! FWIW, I feel that the file should just be named uninstall.md
. The minikube
part is implicit.
@@ -0,0 +1,72 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's odd that it isn't in the preview - if I run make site
locally from this PR, the page shows up.
FWIW, I'm fine with this doc being in the reference section. I don't think this document is likely to be consulted often, but the folks who are looking for it are likely to be desperate for it.
I'm also not going to be terribly particular about what it looks like in this first iteration. I'm just appreciative that it's being done =)
## Binary/Direct | ||
If you have installed minikube using the direct download method, follow the below steps to uninstall minikube completely from your system - | ||
- In the shell, type in `minikube delete` to delete the minikube cluster. | ||
- Remove the binary using `rm /usr/local/bin/minikube` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Let's use sudo here, since in many cases, the regular user won't have access.
|
||
## Chocolatey | ||
If you have installed minikube using Chocolatey package manager, follow the below steps to completely uninstall minikube from your system - | ||
- Open a command prompt with Administrator privileges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these asterisks bullets with no leading whitespace:
* Open a command...
# Uninstall minikube on Windows | ||
Following are the ways you can install minikube on Windows. Depending on how you installed minikube, please follow the guide appropriately. | ||
|
||
## Chocolatey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't consider it neceserray, but if you want to get fancy, you can use the tabs widget that we use in the start docs:
{{% tabs %}}
{{% tab "Direct" %}}
Download and install minikube to /usr/local/bin:
```shell
curl -LO https://storage.googleapis.com/minikube/releases/latest/minikube-linux-amd64 \
&& sudo install minikube-linux-amd64 /usr/local/bin/minikube
{{% /tab %}}
{{% tab "Debian/Ubuntu (deb)" %}}
I understand that you may be flying in the dark due to hugo panic'ing on Windows with our site.
Merging as a clear start is better than nothing. |
Fixes #3372
Could someone do a quick review for MacOS and Linux? I have added the instructions to the best of my knowledge.
Feel free to suggest any edits.
EDIT - I just checked the deploy preview and I am not able to find the page. Any idea what I did wrong?
-Pranav