Unset profile when it is deleted

[josedonizetti]

Fixes #4891

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: josedonizetti
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[medyagh]

Looks good, only one request, could we have a unit test, similar to https://github.com/kubernetes/minikube/tree/master/pkg/minikube/config/testdata/.minikube/

we could have a separate testdata sub folder for it, and have a config file with a different profile set, and expect the Unset to change the file .

[josedonizetti]

@medyagh Didn't understand. A unit test for the minikube delete or for the Unset function?

[medyagh]

@medyagh Didn't understand. A unit test for the minikube delete or for the Unset function?

ideally for both, but the Unset function is first ! priority is, all public functions must have unit tests

[josedonizetti]

@medyagh Unset already have a test. https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/config/unset_test.go

But it can be improved by reading the property after the unset. I'll look into it.

[medyagh]

looks good, ready for merge after test passes