Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to delete all profiles #4780
Added option to delete all profiles #4780
Changes from 23 commits
db6b0a5
08b6edc
6887128
6f2390b
6c4749b
f9e8490
13f40f4
dd9afd1
1d2ead5
72a9493
925e803
3c4b1b1
f0e707c
d0e749b
019ee1f
9e73f6e
09d8143
42a5850
af57143
4c6af02
70f4cb9
48bd69c
e237a13
45161fa
cb58974
6d9ae13
6dcb45a
1ef11bf
96ef740
d4d8cc4
6f81089
a4fd885
d7d05b7
1d9a61f
59eb974
fa0cdbf
342584a
a1d73a7
50329ed
6ed4262
f0dd5a7
229c9b7
4835945
d5bfa87
ba67c85
da1f935
5289e1f
b3741bd
2c6f659
808477a
ea20ba3
0dc7f8d
24d4eda
5b1528b
71a6cb5
01dd044
79e8250
02bea60
42c017f
5cabb01
d52730a
3ec82dd
47ec8d3
c8c4491
e8c997d
4551a17
3396f5b
1efdf11
280e118
8a4b3b9
ae6f47d
ee97b87
b8abe56
0c9cd49
5610849
c4107ae
a0c844e
ae731d4
09ce93f
d13f58f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason to set the profile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to set it because cluster.DeleteHost relies on cfg.GetMachineName(), which uses viper.GetString(MachineProfile).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't set it, the fallback machinename "minikube" is used.