Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit if --kubernetes-version is older than the oldest supported version #4759

Merged
merged 6 commits into from
Sep 5, 2019
+14 −0
Merged

Exit if --kubernetes-version is older than the oldest supported version #4759

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
deead30
start: compare specified kubernetes version with oldest supported ver…
serhatcetinkaya Jul 14, 2019
578e325
Merge remote-tracking branch 'upstream/master'
serhatcetinkaya Sep 1, 2019
2230a52
start: check force flag while comparing specified version
serhatcetinkaya Sep 1, 2019
0b829cc
fix warnings
serhatcetinkaya Sep 1, 2019
14b1d84
start.go rename exit.WithCode with exit.WithCodeT
serhatcetinkaya Sep 1, 2019
23cc018
start.go make err type usable for exit.withCodeT
serhatcetinkaya Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cmd/minikube/cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,6 +848,20 @@ func validateKubernetesVersions(old *cfg.Config) (string, bool) {
return nv, isUpgrade
}

oldestVersion, err := semver.Make(strings.TrimPrefix(constants.OldestKubernetesVersion, version.VersionPrefix))
if err != nil {
exit.WithCodeT(exit.Data, "Unable to parse oldest Kubernetes version from constants: {{.error}}", out.V{"error": err})
}

if nvs.LT(oldestVersion) {
out.WarningT("Specified Kubernetes version {{.specified}} is less than the oldest supported version: {{.oldest}}", out.V{"specified": nvs, "oldest": constants.OldestKubernetesVersion})
if viper.GetBool(force) {
out.WarningT("Kubernetes {{.version}} is not supported by this release of minikube", out.V{"version": nvs})
} else {
exit.WithCodeT(exit.Data, "Sorry, Kubernetes {{.version}} is not supported by this release of minikube", out.V{"version": nvs})
}
}

ovs, err := semver.Make(strings.TrimPrefix(old.KubernetesConfig.KubernetesVersion, version.VersionPrefix))
if err != nil {
glog.Errorf("Error parsing old version %q: %v", old.KubernetesConfig.KubernetesVersion, err)
Expand Down