-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add minikube support for the "generic" VM driver #4734
Conversation
This driver connects to an already existing virtual machine, using the provided IP address and SSH user/key/port parameters. On this machine, libmachine will provision the docker daemon and minikube will bootstrap the kubernetes cluster (as usual).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
could you provide an example with the PR so we have a context ? |
I am thinking if we could use this in the VM-free model too, maybe if the generic driver supports exec-ing into a docker container ? |
The generic driver is quite specific about wanting something to https://github.com/docker/machine/blob/master/drivers/generic/generic.go |
Typical, seems like the generic install (https://get.docker.com) is more strict about security...
That doesn't really work, since minikube normally assumes that user has group access:
|
Added the user to the group, but doesn't work with vagrant since it only uses one IP (i.e. 127.0.0.1)
|
It is not supported anyway, and just throws errors. There is no use to restart or to retry, just give up. This should never be a problem with "none", though. That always return running, while generic tests ssh.
I think I will split this PR |
This PR is not going to be merged (it keeps on breaking!), so mostly using it for testing... |
@afbjorklund: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This driver connects to an already existing virtual machine,
using the provided IP address and SSH user/key/port parameters.
On this machine, libmachine will provision the docker daemon
and minikube will bootstrap the kubernetes cluster (as usual).
Implements #4733