Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add platform specific phony targets #4579

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

blueelvis
Copy link
Contributor

  1. Added platform specific Phony targets (Linux, Windows & Darwin)
  2. Added Documentation in the build instructions about this.
  3. Changed cp to mv to remove a duplicate file.

Fixes #4458

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @blueelvis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 24, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: blueelvis
To complete the pull request process, please assign balopat
You can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@medyagh medyagh changed the title Add Platform Specific Phony Targets Makefile: add platform specific phony targets Jun 25, 2019
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@medyagh medyagh merged commit d048858 into kubernetes:master Jun 25, 2019
@afbjorklund
Copy link
Collaborator

afbjorklund commented Jul 31, 2019

BTW; the change from cp to mv now caused windows to be rebuilt everytime... Not good.

Would rather have duplicate files, than having to rebuild it because something removed output.

Reverted in 2fe7856

@blueelvis
Copy link
Contributor Author

@afbjorklund - How about we directly output as .exe? That would give best of both options.

@afbjorklund
Copy link
Collaborator

Yeah, but it is harder to write the make rules. So best would be if Windows stopped with the DOS :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability in Make to build specific platforms
5 participants