Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a default NFS mount for /Users with xhyve #434

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Aug 1, 2016

Removing the Virtio9p flags from the xhyve-driver struct because they
require custom configuration of the boot2docker iso and thus won't
work. See this note for more information
https://github.com/zchee/docker-machine-driver-xhyve#usage

This resolves issue #423

Additionally, let me know if anyone thinks we should keep around the virtio9p flags for now or if we should not mount the folder by default and instead have to pass a flag or something.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Aug 1, 2016

@minikube-bot add to whitelist

@r2d4
Copy link
Contributor Author

r2d4 commented Aug 2, 2016

I was able to get virtio9p working with @dlorenc's fork of https://github.com/dlorenc/docker-machine-driver-xhyve/tree/err

Virtio9p is not included in the lastest release of docker-machine-xhyve-driver. I guess lets look into how we can work with @zchee

@zchee
Copy link
Contributor

zchee commented Aug 2, 2016

@r2d4 Hi,
I received a contact from @Florenc.
I still don't understand all that minikube team wants to behavior, but I might be able to help.
Also, I planned resume maintenance my repository.

I will look back own code, and begin to read the minikube' code (a little).
So please wait for a little.

@dlorenc
Copy link
Contributor

dlorenc commented Aug 8, 2016

@r2d4 can you test this with the new docker-machine-driver-xhyve build? If it works there we can merge. The homebrew update hasn't gone in yet, but this is a no-op with older versions so it should be safe.

@zchee
Copy link
Contributor

zchee commented Aug 8, 2016

@r2d4 @dlorenc Now merged my pull request that update to v0.2.3. It's already support lib9p by default.
Homebrew/homebrew-core@ee1b877

@r2d4
Copy link
Contributor Author

r2d4 commented Aug 9, 2016

@dlorenc tested with v0.2.3 of the xhyve driver and it works fine. I added back the flags for virtio9p and enabled them by default

@dlorenc
Copy link
Contributor

dlorenc commented Aug 9, 2016

Would you mind squashing commits?

This feature is enabled in v0.2.3 of the docker xhyve driver
Enabling this by default on cluster_darwin

This resolves issue kubernetes#423
@r2d4
Copy link
Contributor Author

r2d4 commented Aug 9, 2016

squashed

@dlorenc
Copy link
Contributor

dlorenc commented Aug 9, 2016

LGTM

@dlorenc dlorenc merged commit 24a20d6 into kubernetes:master Aug 9, 2016
@r2d4 r2d4 deleted the xhyve-nfs-mnt branch August 13, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants