-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a default NFS mount for /Users with xhyve #434
Conversation
Can one of the admins verify this patch? |
@minikube-bot add to whitelist |
I was able to get virtio9p working with @dlorenc's fork of https://github.com/dlorenc/docker-machine-driver-xhyve/tree/err Virtio9p is not included in the lastest release of docker-machine-xhyve-driver. I guess lets look into how we can work with @zchee |
@r2d4 can you test this with the new docker-machine-driver-xhyve build? If it works there we can merge. The homebrew update hasn't gone in yet, but this is a no-op with older versions so it should be safe. |
@r2d4 @dlorenc Now merged my pull request that update to v0.2.3. It's already support lib9p by default. |
@dlorenc tested with v0.2.3 of the xhyve driver and it works fine. I added back the flags for virtio9p and enabled them by default |
Would you mind squashing commits? |
This feature is enabled in v0.2.3 of the docker xhyve driver Enabling this by default on cluster_darwin This resolves issue kubernetes#423
squashed |
LGTM |
Removing the Virtio9p flags from the xhyve-driver struct because they
require custom configuration of the boot2docker iso and thus won't
work. See this note for more information
https://github.com/zchee/docker-machine-driver-xhyve#usage
This resolves issue #423
Additionally, let me know if anyone thinks we should keep around the virtio9p flags for now or if we should not mount the folder by default and instead have to pass a flag or something.