-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test case for minikube config unset #4262
Conversation
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: hpandeycodeit If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
import "testing" | ||
|
||
func TestUnsetConfig(t *testing.T) { | ||
err := Set("dashboard", "true") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to check this err too.
err := Set("dashboard", "true") | ||
err = unset("dashboard") | ||
if err != nil { | ||
t.Fatalf("Failed to unset property ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer t.Errorf over t.Fatalf whenever possible. That way you can see more failed test information without rerunning it later. In this particular case, it doesn't change the behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out. I have updated it.
@minikube-bot OK to test |
Test failed with:
The error mentioned is new, but shouldn't be fatal. It's curious that the actual name of the failing test isn't being displayed though? I wonder if this is unintended fall-out from #4253 Do you mind merging your PR from head? I'm curious if |
@tstromberg It's working fine in my local even after merging changes from the HEAD.
|
e22f863
to
558444d
Compare
/retest |
@minikube-bot OK to test |
@minikube-bot OK to test |
/ok-to-test |
Thank you for improving our test coverage! |
Thank you @tstromberg! :) |
Added Test Case for
minikube config unset
.