Reroute browser logout from stdout #4237
Conversation
|
Hi @medyagh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: medyagh If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
I'm concerned that this may hide valuable error messages for users to debug why their browser isn't opening. For instance: #2548 Thoughts? |
There was a problem hiding this comment.
I'm concerned that this may hide valuable error messages for users to debug why their browser isn't opening. For instance: #2548
Thoughts?
That's a good concern, one possible solution is we could do give them a heads up the in the console output "Tip: browser logs are available by minikube logs " command so if something goes wrong they know where to look for it.
| if err != nil { | ||
| glog.Errorf("Error setting dashboard's log output pipe %s", err) | ||
| } | ||
| log.SetOutput(w) |
|
Given that this seems to happen only on certain linux configurations, and the browser output might be helpful. I am okay with closing this PR. |
Reroutes the logs from the browser (for the dashboard addon) not to flood the stdout and stderr
Fixes #4235