-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DefaultMountVersion to 9p2000.L #3796
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kron4eg If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@minikube-bot OK to test |
I think this PR is a great idea. Thanks for proposing it! Will approve once I can see that the integration tests pass. |
Looks OK, but I think we need to also upgrade the server for it to be of most use ? |
@afbjorklund I'm not sure I got you. Do you mean |
@minikube-bot OK to test FWIW, I think updating the server is unrelated to this version change. L has been around for a very long time. |
@kron4eg yes, I think that is serving ? |
Afaik, it will negotiate. So we should start with updating this client, but also update server |
Unfortunately I can't find from where |
9p2000.u is a legacy protocol version. This upgrades us to the most recent version with better permissions handling. From the Linux kernel docs: https://landley.net/kdocs/Documentation/filesystems/9p.txt
Fixes #2290