Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable auto-update #375

Closed
wants to merge 2 commits into from
Closed

Enable auto-update #375

wants to merge 2 commits into from

Conversation

jimmidyson
Copy link
Member

Fixe #373

dlorenc
dlorenc reviewed Jul 21, 2016
View reviewed changes
pkg/minikube/update/update.go
"github.com/spf13/viper"
"k8s.io/minikube/pkg/minikube/config"
"k8s.io/minikube/pkg/minikube/constants"
"k8s.io/minikube/pkg/version"
)

const updateLinkPrefix = "https://github.com/kubernetes/minikube/releases/tag/v"
const downloadLinkFormat = "https://github.com/kubernetes/minikube/releases/download/v%s/%s"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had trouble hitting github rate limits when querying URLs like this. Have you seen anything like that yet? What do you think about extending the releases.json file to contain the SHA instead of hitting Github?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that. I always use API tokens so don't hit those limits but most users probably won't do that.

Yeah updating release json makes a lot of sense. Need to automate the release process to add this in but will document it for now.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 21, 2016

High-level question, how do you see this working with multiple binaries (when we start bundling the drivers, for example)?

@jimmidyson
Copy link
Member Author

Not sure, we could do it with a self extracting binary, using the same go-bindata we use for localkube?

@dlorenc
Copy link
Contributor

dlorenc commented Jul 25, 2016

Would you mind holding onto this until we figure out the packaging story a little more? I want to make sure whatever auto-update we get in place works once we have OS-specific installers (brew, .msi, .deb/.rpm, etc.) that bundle several binaries.

@jimmidyson
Copy link
Member Author

100% agree. If we're using OS-specific installers then I wouldn't want to do autoupdate, we can leave that up to the package manager, can't we?

@dlorenc dlorenc removed kind/feature Categorizes issue or PR as related to a new feature. kind/enhancement labels Aug 11, 2016
@abitrolly
Copy link
Contributor

I'd like to have this in minikube. What is the resolution?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 19, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 16, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jimmidyson @dlorenc @abitrolly @fejta-bot @googlebot @k8s-ci-robot