Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix netstat -f error on linux distros #3592

Merged
merged 3 commits into from
Jan 28, 2019
Merged

fix netstat -f error on linux distros #3592

merged 3 commits into from
Jan 28, 2019

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Jan 26, 2019

Fixes #3498

@balopat balopat added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2019
@balopat
Copy link
Contributor Author

balopat commented Jan 26, 2019

Hmm...so route is not on the $PATH

@tstromberg
Copy link
Contributor

tstromberg commented Jan 28, 2019 •
edited
Loading

Hmm...so route is not on the $PATH

route lives in /sbin, because it's only meant to be run by root, and thus not typically in PATH. The good news is that this location is standardized by FSHB (and thus FSB), so you can safely hardcode the location for Linux: http://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s16.html

Unrelated, but FYI, route was also deprecated in favor of ip r in Linux:

https://dougvitale.wordpress.com/2011/12/21/deprecated-linux-networking-commands-and-their-replacements/

tstromberg
tstromberg suggested changes Jan 28, 2019
View reviewed changes
pkg/minikube/tunnel/route_linux.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: balopat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2019
@balopat balopat added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7ccfe51 into kubernetes:master Jan 28, 2019
@zak905
Copy link

zak905 commented Feb 11, 2019

Hi, any idea when this will be released ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg requested changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balopat @tstromberg @k8s-ci-robot @zak905