Still generate docker.service unit, even if unused

[afbjorklund]

The dynamically generated docker.service file should still be there,
otherwise the statically provided docker.socket file gets confused.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: afbjorklund
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: balopat

If they are not already assigned, you can assign the PR to them by writing /assign @balopat in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gbraad]

otherwise the statically provided docker.socket file gets confused.

who creates this file? Else I would move this out and make this part of the actual service unit instead. This seems like a workaround instead of addressing the actual issue.

[afbjorklund]

It is included in the ISO, they used to both be before the service unit was configurable

Here: 56e250e and 0db44af

[gbraad]

I would suggest to not use docker.socket as systemd-unit by default, unless Docker is really used as the container runtime... cause I think you are tryin to solve this for when an alternative runtime is used. like cri-o. Right?

[afbjorklund]

Since we are using docker-machine to create the VM, then docker is supposed to always be there when we start - and then we stop it and start the desired runtime before starting up the rest of kubernetes.
The file was there before, but it was removed by mistake in ed8f712 . A better fix would be to move the configuration out of the unit, so that it can be included in the ISO file. For instance to /etc/docker.