Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRI-O to TestStartStop #3536

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Conversation

tstromberg
Copy link
Contributor

This helps us from accidentally breaking CRI-O support in future PR's.

This PR does fall short of running all tests in CRI-O, but that will have to wait for the Prow migration where we can run more advanced test matrixes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@tstromberg
Copy link
Contributor Author

@minikube-bot OK to test

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 17, 2019
@afbjorklund
Copy link
Collaborator

LGTM, possibly add --network-plugin=cni ?

@afbjorklund
Copy link
Collaborator

The documentation even says:

$ minikube start \
    --network-plugin=cni \
    --enable-default-cni \
    --container-runtime=cri-o

https://github.com/kubernetes/minikube/blob/master/docs/alternative_runtimes.md#using-cri-o

So should probably use the exact same parameters, when testing ?

i.e. --enable-default-cni too

@tstromberg
Copy link
Contributor Author

The documentation even says:

$ minikube start \
    --network-plugin=cni \
    --enable-default-cni \
    --container-runtime=cri-o

https://github.com/kubernetes/minikube/blob/master/docs/alternative_runtimes.md#using-cri-o

So should probably use the exact same parameters, when testing ?

i.e. --enable-default-cni too

I shouldn't have to look at documentation to select a container runtime - our defaults are terrible. Opened #3567 to address. Updated PR.

@tstromberg tstromberg merged commit c27d1a0 into kubernetes:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants