-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRI-O to TestStartStop #3536
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@minikube-bot OK to test |
LGTM, possibly add |
The documentation even says: $ minikube start \
--network-plugin=cni \
--enable-default-cni \
--container-runtime=cri-o https://github.com/kubernetes/minikube/blob/master/docs/alternative_runtimes.md#using-cri-o So should probably use the exact same parameters, when testing ? i.e. |
I shouldn't have to look at documentation to select a container runtime - our defaults are terrible. Opened #3567 to address. Updated PR. |
This helps us from accidentally breaking CRI-O support in future PR's.
This PR does fall short of running all tests in CRI-O, but that will have to wait for the Prow migration where we can run more advanced test matrixes.