-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRI socket in Kubernetes >= 1.12.0 kubeadmin config #3452
Fix CRI socket in Kubernetes >= 1.12.0 kubeadmin config #3452
Conversation
Use CRI socket from parameter for V1Alpha3 configs instead of hardcoded dockershim path
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ceache If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
I actually already have signed the CLA. What am I missing? |
I signed it |
@ceache have you signed individual CLA? |
/check-cla |
I did, yes. On the linux fundation page, I can see the "CNCF" under projects and my github handle under "social network logins" |
@ceache please click on the link sign in as employee or individual whatever applies to you, would get welcome message on linux foundation page |
I signed it |
@RA489 thanks for the help. I was clearly being an idiot. Cheers |
@minikube-bot OK to test |
restarted the travis ci build - I've seen this error before where asset is missing. It's odd, if it comes up again, I'll dig a bit deeper. |
Linux-None: known flake: #3381 |
Use CRI socket from parameter for V1Alpha3 configs instead of hardcoded
dockershim path