Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRI socket in Kubernetes >= 1.12.0 kubeadmin config #3452

Merged
merged 1 commit into from
Dec 20, 2018

Conversation

ceache
Copy link
Contributor

@ceache ceache commented Dec 13, 2018

Use CRI socket from parameter for V1Alpha3 configs instead of hardcoded
dockershim path

Use CRI socket from parameter for V1Alpha3 configs instead of hardcoded
dockershim path
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 13, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ceache
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@RA489
Copy link

RA489 commented Dec 14, 2018

@ceache
Copy link
Contributor Author

ceache commented Dec 14, 2018

I actually already have signed the CLA. What am I missing?

@ceache
Copy link
Contributor Author

ceache commented Dec 14, 2018

I signed it

@RA489
Copy link

RA489 commented Dec 14, 2018

@ceache have you signed individual CLA?

@RA489
Copy link

RA489 commented Dec 14, 2018

/check-cla

@ceache
Copy link
Contributor Author

ceache commented Dec 14, 2018

I did, yes. On the linux fundation page, I can see the "CNCF" under projects and my github handle under "social network logins"

@RA489
Copy link

RA489 commented Dec 14, 2018

@ceache please click on the link sign in as employee or individual whatever applies to you, would get welcome message on linux foundation page

@ceache
Copy link
Contributor Author

ceache commented Dec 14, 2018

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 14, 2018
@ceache
Copy link
Contributor Author

ceache commented Dec 14, 2018

@RA489 thanks for the help. I was clearly being an idiot. Cheers

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@balopat
Copy link
Contributor

balopat commented Dec 20, 2018

restarted the travis ci build - I've seen this error before where asset is missing. It's odd, if it comes up again, I'll dig a bit deeper.

@balopat
Copy link
Contributor

balopat commented Dec 20, 2018

Linux-None: known flake: #3381
Linux-VirtualBox: I think those 4 are all flakes...especially that this change is not covered in integration tests as the current default is 1.10.
I'm pro merging this - this was one of the root causes of gvisor addon incompatibility with 1.12.

@balopat balopat merged commit 2cabcd5 into kubernetes:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants