Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gvisor addon in minikube #3399

Merged
merged 27 commits into from
Dec 7, 2018
Merged

Commits on Dec 3, 2018

  1. Add integration test to make sure minikube starts and stops with cont…

    …ainerd
    Priya Wadhwa committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    04c1215 View commit details
    Browse the repository at this point in the history
  2. Skip testing containerd if using none driver

    Priya Wadhwa committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    01ad85e View commit details
    Browse the repository at this point in the history
  3. add newline

    Priya Wadhwa committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    8c7290f View commit details
    Browse the repository at this point in the history
  4. Fixed imports

    Priya Wadhwa committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    e385449 View commit details
    Browse the repository at this point in the history
  5. Add skip message when using none driver and containerd

    Priya Wadhwa committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    40ad9e7 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Enable gvisor addon in minikube

    This PR adds the code for enabling gvisor in minikube. It adds the pod
    that will run when the addon is enabled, and the code for the image
    which will run when this happens.
    
    When gvisor is enabled, the pod will download runsc and the
    gvisor-containerd-shim. It will replace the containerd config.toml and
    restart containerd.
    
    When gvisor is disabled, the pod will be deleted by the addon manager.
    This will trigger a pre-stop hook which will revert the config.toml to
    it's original state and restart containerd.
    Priya Wadhwa committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    85a4b8b View commit details
    Browse the repository at this point in the history
  2. Added doc for enabling gvisor in minikube

    Priya Wadhwa committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    f885f4b View commit details
    Browse the repository at this point in the history
  3. Code review comments

    Instead of checking in default config.toml, save it at /tmp/config.toml
    on the node upon enable and copy it back upon disable.
    
    Also, instead of using the prestop hook, intercept the SIGTERM kill signal upon pod
    termination, disable gvisor, and then exit with code 0. This should work
    better because now we will be able to see the logs from disabling, and
    because the prestop hook wouldn't consistenly run the disable command
    and clean up the pod correctly.
    Priya Wadhwa committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    ac963e2 View commit details
    Browse the repository at this point in the history
  4. Simplify gvisor and check for containerd runtime

    When enabling gvisor, first validate that the container runtime is
    containerd.
    Priya Wadhwa committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    c894943 View commit details
    Browse the repository at this point in the history
  5. small improvements

    Priya Wadhwa committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    f9915ac View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Merge branch 'integration' of github.com:priyawadhwa/minikube into gv…

    …isoraddon
    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    81948f0 View commit details
    Browse the repository at this point in the history
  2. Add gvisor integration test

    Added integration test which follows these steps:
    
    1. enable gvisor
    2. make sure untrusted workload runs correctly
    3. disable gvisor
    4. make sure untrusted workload results in FailedCreateSandboxEvent
    event
    
    I also added a link to the iso url for starting containerd until the
    integration tests start using the new version of the iso.
    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    4a8de41 View commit details
    Browse the repository at this point in the history
  3. Fixed merge conflict

    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    fd1f375 View commit details
    Browse the repository at this point in the history
  4. Show gvisor pod logs upon test failure

    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    7bee870 View commit details
    Browse the repository at this point in the history
  5. Additional logs

    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    765cc93 View commit details
    Browse the repository at this point in the history
  6. Code review comments and added logs

    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    6e6020f View commit details
    Browse the repository at this point in the history
  7. Remove default runsc debug as it's too verbose

    Priya Wadhwa committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1c01497 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. change iso url

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    830f8f8 View commit details
    Browse the repository at this point in the history
  2. More logs

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    2ec2e53 View commit details
    Browse the repository at this point in the history
  3. Code review comments and additional logs

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    a3cb54c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    420eb32 View commit details
    Browse the repository at this point in the history
  5. delete minikube in test before starting with containerd

    also remove extra logs
    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    0e4a28c View commit details
    Browse the repository at this point in the history
  6. delete after finishing up containerd

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    c976e11 View commit details
    Browse the repository at this point in the history
  7. Add minikube User-Agent to requests for shim and runsc

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    1073ea0 View commit details
    Browse the repository at this point in the history
  8. Only delete minikube if there is already one running

    Priya Wadhwa committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    af6d30b View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Configuration menu
    Copy the full SHA
    fdfa42a View commit details
    Browse the repository at this point in the history
  2. update gvisor url

    Priya Wadhwa committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    c7e5341 View commit details
    Browse the repository at this point in the history