-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable gvisor addon in minikube #3399
Commits on Dec 3, 2018
-
Add integration test to make sure minikube starts and stops with cont…
…ainerd
Priya Wadhwa committedDec 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 04c1215 - Browse repository at this point
Copy the full SHA 04c1215View commit details -
Skip testing containerd if using none driver
Priya Wadhwa committedDec 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 01ad85e - Browse repository at this point
Copy the full SHA 01ad85eView commit details -
Priya Wadhwa committed
Dec 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 8c7290f - Browse repository at this point
Copy the full SHA 8c7290fView commit details -
Priya Wadhwa committed
Dec 3, 2018 Configuration menu - View commit details
-
Copy full SHA for e385449 - Browse repository at this point
Copy the full SHA e385449View commit details -
Add skip message when using none driver and containerd
Priya Wadhwa committedDec 3, 2018 Configuration menu - View commit details
-
Copy full SHA for 40ad9e7 - Browse repository at this point
Copy the full SHA 40ad9e7View commit details
Commits on Dec 4, 2018
-
Enable gvisor addon in minikube
This PR adds the code for enabling gvisor in minikube. It adds the pod that will run when the addon is enabled, and the code for the image which will run when this happens. When gvisor is enabled, the pod will download runsc and the gvisor-containerd-shim. It will replace the containerd config.toml and restart containerd. When gvisor is disabled, the pod will be deleted by the addon manager. This will trigger a pre-stop hook which will revert the config.toml to it's original state and restart containerd.
Priya Wadhwa committedDec 4, 2018 Configuration menu - View commit details
-
Copy full SHA for 85a4b8b - Browse repository at this point
Copy the full SHA 85a4b8bView commit details -
Added doc for enabling gvisor in minikube
Priya Wadhwa committedDec 4, 2018 Configuration menu - View commit details
-
Copy full SHA for f885f4b - Browse repository at this point
Copy the full SHA f885f4bView commit details -
Instead of checking in default config.toml, save it at /tmp/config.toml on the node upon enable and copy it back upon disable. Also, instead of using the prestop hook, intercept the SIGTERM kill signal upon pod termination, disable gvisor, and then exit with code 0. This should work better because now we will be able to see the logs from disabling, and because the prestop hook wouldn't consistenly run the disable command and clean up the pod correctly.
Priya Wadhwa committedDec 4, 2018 Configuration menu - View commit details
-
Copy full SHA for ac963e2 - Browse repository at this point
Copy the full SHA ac963e2View commit details -
Simplify gvisor and check for containerd runtime
When enabling gvisor, first validate that the container runtime is containerd.
Priya Wadhwa committedDec 4, 2018 Configuration menu - View commit details
-
Copy full SHA for c894943 - Browse repository at this point
Copy the full SHA c894943View commit details -
Priya Wadhwa committed
Dec 4, 2018 Configuration menu - View commit details
-
Copy full SHA for f9915ac - Browse repository at this point
Copy the full SHA f9915acView commit details
Commits on Dec 5, 2018
-
Merge branch 'integration' of github.com:priyawadhwa/minikube into gv…
…isoraddon
Priya Wadhwa committedDec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 81948f0 - Browse repository at this point
Copy the full SHA 81948f0View commit details -
Added integration test which follows these steps: 1. enable gvisor 2. make sure untrusted workload runs correctly 3. disable gvisor 4. make sure untrusted workload results in FailedCreateSandboxEvent event I also added a link to the iso url for starting containerd until the integration tests start using the new version of the iso.
Priya Wadhwa committedDec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 4a8de41 - Browse repository at this point
Copy the full SHA 4a8de41View commit details -
Priya Wadhwa committed
Dec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for fd1f375 - Browse repository at this point
Copy the full SHA fd1f375View commit details -
Show gvisor pod logs upon test failure
Priya Wadhwa committedDec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 7bee870 - Browse repository at this point
Copy the full SHA 7bee870View commit details -
Priya Wadhwa committed
Dec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 765cc93 - Browse repository at this point
Copy the full SHA 765cc93View commit details -
Code review comments and added logs
Priya Wadhwa committedDec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 6e6020f - Browse repository at this point
Copy the full SHA 6e6020fView commit details -
Remove default runsc debug as it's too verbose
Priya Wadhwa committedDec 5, 2018 Configuration menu - View commit details
-
Copy full SHA for 1c01497 - Browse repository at this point
Copy the full SHA 1c01497View commit details
Commits on Dec 6, 2018
-
Priya Wadhwa committed
Dec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 830f8f8 - Browse repository at this point
Copy the full SHA 830f8f8View commit details -
Priya Wadhwa committed
Dec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 2ec2e53 - Browse repository at this point
Copy the full SHA 2ec2e53View commit details -
Code review comments and additional logs
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for a3cb54c - Browse repository at this point
Copy the full SHA a3cb54cView commit details -
Merge branch 'master' of github.com:kubernetes/minikube into gvisoraddon
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 420eb32 - Browse repository at this point
Copy the full SHA 420eb32View commit details -
delete minikube in test before starting with containerd
also remove extra logs
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 0e4a28c - Browse repository at this point
Copy the full SHA 0e4a28cView commit details -
delete after finishing up containerd
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for c976e11 - Browse repository at this point
Copy the full SHA c976e11View commit details -
Add minikube User-Agent to requests for shim and runsc
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 1073ea0 - Browse repository at this point
Copy the full SHA 1073ea0View commit details -
Only delete minikube if there is already one running
Priya Wadhwa committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for af6d30b - Browse repository at this point
Copy the full SHA af6d30bView commit details
Commits on Dec 7, 2018
-
Merge branch 'master' of github.com:kubernetes/minikube into gvisoraddon
Priya Wadhwa committedDec 7, 2018 Configuration menu - View commit details
-
Copy full SHA for fdfa42a - Browse repository at this point
Copy the full SHA fdfa42aView commit details -
Priya Wadhwa committed
Dec 7, 2018 Configuration menu - View commit details
-
Copy full SHA for c7e5341 - Browse repository at this point
Copy the full SHA c7e5341View commit details