Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of logviewer addon #3391

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

ivans3
Copy link
Contributor

@ivans3 ivans3 commented Dec 2, 2018

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivans3
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 2, 2018
@balopat
Copy link
Contributor

balopat commented Dec 20, 2018

@minikube-bot OK to test

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ivans3 - thank you for the contribution. I am worried about endorsing this addon just yet because the logviewer

  • has binaries (xtail) in the github repo instead of traceable/trustworthy places - this needs to be fixed with checksums/etc.
  • is a couple of months old but it looks like it has not seen much usage yet, no issues/PRs have been opened
  • has only 1 contributor - theoretically addons are "well maintained" - installing products backed by potentially more than 1 person.

Idea: maybe you could start a "Community addons" section here that could point to your repository. That might generate enough traffic and interest?

@ivans3
Copy link
Contributor Author

ivans3 commented Dec 22, 2018

Hi @balopat ,

Thanks for your feedback and suggestions, I really appreciate it!

The xtail binary is built from debian source only adding the "-static" option to the build.
I will update my project to include the xtail source and checksums.

So you are saying to abandon this PR for now, and make a new one only for the addons.md file
to add a new "Community addons" section?

@tstromberg tstromberg merged commit b61207c into kubernetes:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants