Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images and improve parsing for kubernetes 1.11 #3262

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

mlgibbons
Copy link
Contributor

Updated parsing logic to handle K8S v1.11 in same fashion as other versions

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@mlgibbons mlgibbons changed the title Updated to add parsing for k8s v1.11 Add images and improve parsing for kubernetes 1.11 Oct 18, 2018
@mlgibbons
Copy link
Contributor Author

/assign tstromberg

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg tstromberg added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2018
@mlgibbons
Copy link
Contributor Author

This change addresses some issues with the list of images which were cached for K8S v1.11.0 and which were detected during additional offline testing. An issue has been raised against kubeadm - kubernetes/kubeadm#1198 - in relation to the incorrect images being returned for coredns and pause.

@mlgibbons
Copy link
Contributor Author

Bug confirmed in kubeadm 1.11 and fixed in 1.12 - kubernetes/kubeadm#1198 - see comment in issue.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@RA489
Copy link

RA489 commented Dec 7, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mlgibbons, RA489

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@RA489: changing LGTM is restricted to assignees, and only kubernetes/minikube repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mlgibbons
Copy link
Contributor Author

@tstromberg I'm wondering what is preventing this from being merged? What's the next step?

@tstromberg
Copy link
Contributor

Sorry for the delay - we needed to take some time to stabilize our CI infrastructure. Will review after test results are updated.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@mlgibbons
Copy link
Contributor Author

@tstromberg Thanks. I see that the changes are approved but I'm unclear if the tests which are required are complete - there seem to be a lot pending. We need to upgrade to our minikube version to 0.32 to address a dashboard CVE but need this change in there hence my desire to understand when they'll be merged to master. Thanks.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

1 similar comment
@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg tstromberg merged commit a130a09 into kubernetes:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants