Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "kubectl proxy" instead of a NodePort to expose the dashboard. #3210

Merged
merged 16 commits into from
Oct 4, 2018
Merged

Use "kubectl proxy" instead of a NodePort to expose the dashboard. #3210

merged 16 commits into from
Oct 4, 2018

Conversation

tstromberg
Copy link
Contributor

This provides an additional level of security, by enforcing host checking, applying port randomization, and requiring explicit user intent to expose the service to the host.

This addresses #3208

@tstromberg
Use "kubectl proxy" instead of a NodePort to expose the dashboard.
df54c6a 
This provides an additional level of security, by enforcing host checking, applying port randomization, and requiring explicit user intent to expose the service to the host.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 3, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2018
@tstromberg
Fix service port indentation.
21776a0
@tstromberg
Improve readability of ISO download errors + include URL.
bc2dbe3 
This is a separate issue I bumped into while developing the dashboard
PR.
@tstromberg
Switch the label back to k8s-app instead of app for minikube compatib…
ca9ca6f 
…ility.
@tstromberg
Block until the proxy URL is healthy.
8fd45bc 
This is necessary now that there is no proper service endpoint to block
on.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 3, 2018
@tstromberg tstromberg changed the title WIP/DO NOT REVIEW: Use "kubectl proxy" instead of a NodePort to expose the dashboard. WIP: Use "kubectl proxy" instead of a NodePort to expose the dashboard. Oct 3, 2018
gbraad
gbraad reviewed Oct 3, 2018
View reviewed changes
pkg/minikube/cluster/cluster.go Outdated Show resolved Hide resolved
pkg/util/downloader.go Outdated Show resolved Hide resolved
test/integration/mount_test.go Show resolved Hide resolved
@tstromberg tstromberg changed the title WIP: Use "kubectl proxy" instead of a NodePort to expose the dashboard. Use "kubectl proxy" instead of a NodePort to expose the dashboard. Oct 3, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2018
balopat
balopat suggested changes Oct 3, 2018
View reviewed changes
cmd/minikube/cmd/dashboard.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/dashboard.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/dashboard.go Outdated Show resolved Hide resolved
cmd/minikube/cmd/dashboard.go Show resolved Hide resolved
cmd/minikube/cmd/dashboard.go Show resolved Hide resolved
cmd/minikube/cmd/dashboard.go Show resolved Hide resolved
balopat
balopat approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - please fix the lint.

@tstromberg
Merge branch 'master' into dashboard_on_demand
dc6d1ba
@tstromberg
Let gofmt 1.10.4 rewrite service_test.go.
687b62c 
NOTE: This differs against what 1.11 would do, but matches our current
Travis CI configuration.
@tstromberg tstromberg merged commit 583937a into kubernetes:master Oct 4, 2018
@tstromberg tstromberg mentioned this pull request Oct 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidovich davidovich davidovich left review comments

@gbraad gbraad gbraad left review comments

@balopat balopat balopat approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tstromberg @k8s-ci-robot @gbraad @balopat @davidovich