Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make k8s v1.10.8 (was: v1.11.0) available by default #3132

Closed
wants to merge 4 commits into from
Closed

Make k8s v1.10.8 (was: v1.11.0) available by default #3132

wants to merge 4 commits into from

Conversation

alex-leonhardt
Copy link

Enables v1.11.0 and sets it to be the default version.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@alex-leonhardt
Copy link
Author

I inline updated the 2 files, which is probably why the CLA doesn't match...

/assign @jimmidyson

@alex-leonhardt
Copy link
Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 16, 2018
@@ -101,4 +104,4 @@
{
"version": "v1.3.0"
}
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you add the newline back?

@dlorenc
Copy link
Contributor

dlorenc commented Sep 17, 2018

@minikube-bot OK to test

@alex-leonhardt
Copy link
Author

Hmm - not sure how the version bump broke this

Sep 17 22:02:36 kvm-integration-slave kubelet[19302]: I0917 22:02:36.265112   19302 feature_gate.go:230] feature gates: &{map[]}
Sep 17 22:02:36 kvm-integration-slave kubelet[19302]: I0917 22:02:36.265410   19302 plugins.go:97] No cloud provider specified.
Sep 17 22:02:36 kvm-integration-slave kubelet[19302]: F0917 22:02:36.265605   19302 server.go:262] failed to run Kubelet: unable to load bootstrap kubeconfig: stat /etc/kubernetes/bootstrap-kubelet.conf: no such file or directory

Above is the last failures I saw from the log on Linux-None.

@alex-leonhardt
Copy link
Author

Just saw

		[init] using Kubernetes version: v1.11.0
		[preflight] running pre-flight checks
			[WARNING FileExisting-socat]: socat not found in system path
		I0917 22:02:34.410548   19189 kernel_validator.go:81] Validating kernel version
		I0917 22:02:34.410624   19189 kernel_validator.go:96] Validating kernel config
			[WARNING SystemVerification]: docker version is greater than the most recently validated version. Docker version: 17.07.0-ce. Max validated version: 17.03
			[WARNING Hostname]: hostname "minikube" could not be reached
			[WARNING Hostname]: hostname "minikube" lookup minikube on 169.254.169.254:53: no such host
		[preflight] Some fatal errors occurred:
			[ERROR FileExisting-crictl]: crictl not found in system path

the actual error, I guess, is .. [ERROR FileExisting-crictl]: crictl not found in system path, in the Linux-None test output ... (line 235, 236) and

		E0917 22:02:35.007986   19147 start.go:297] Error starting cluster:  kubeadm init error 

on line 219 though that's just out of order, the above errors happen before this one.

Hope that helps somehow?

@afbjorklund
Copy link
Collaborator

afbjorklund commented Sep 22, 2018

@alex-leonhardt : you don't have to update k8s_releases.json, since it is only used for localkube (not for kubeadm) and only after it has been uploaded to the GCS location and made available for download... https://storage.googleapis.com/minikube/k8s_releases.json

Most likely, that file should be deleted now.

But the about socat/crictl errors are weird.

@afbjorklund
Copy link
Collaborator

Hmm, Docker version: 17.07.0-ce doesn't sound like the minikube.iso.
Maybe running on the localhost, without recommended packages installed ?

Promoting crictl from a WARNING to an ERROR is new, see: kubernetes/kubeadm#942
Now (1.11+) everyone needs to install "cri-tools", before running "kubeadm"

Unfortunately this is mostly* undocumented for anything but Container Linux:
https://kubernetes.io/docs/setup/independent/install-kubeadm/#before-you-begin

It is normally downloaded from https://github.com/kubernetes-sigs/cri-tools
For the minikube.iso, we build it from source (currently version v1.11.1)

@alex-leonhardt
Copy link
Author

Is there anything I can do, or do we need to wait for #3150 to be completed?

@afbjorklund
Copy link
Collaborator

@alex-leonhardt : probably better to move to v1.10.8 as the default version, while minikube support for 1.11 and 1.12 stabilizes ? Users can always chose a later version using --kubernetes-version

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2018
@alex-leonhardt alex-leonhardt changed the title Make k8s v1.11.0 available by default Make k8s v1.10.8 (was: v1.11.0) available by default Sep 29, 2018
@bhack
Copy link

bhack commented Sep 29, 2018

I think that we have still some issue related to systemd-resolv in v1.10.x expecially for vm-driver=none. See kubernetes/kubeadm#845

@tstromberg tstromberg added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: alex-leonhardt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alex-leonhardt
Copy link
Author

ok, so now it's "too old" and has a conflict in deploy/minikube/k8s_releases.json - I'll just close this PR as it's not progressing (not all tests run, no idea why) - seems quite a simple change that didn't go through after even 3 weeks.

@afbjorklund
Copy link
Collaborator

The basic idea (upgrade the kubernetes version) is still valid, even though the Pull Request wasn't.
Note that you can still use the newer versions, and that localkube (k8s_releases.json) is removed.

@tstromberg : something to consider for the next release, perhaps ? (v1.10.0 is somewhat buggy)

@afbjorklund
Copy link
Collaborator

@alex-leonhardt : minikube config set kubernetes-version v1.10.8 (no patches required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants