-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make k8s v1.10.8 (was: v1.11.0) available by default #3132
Conversation
k8s v1.11.0 is out
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Can one of the admins verify this patch? |
I inline updated the 2 files, which is probably why the CLA doesn't match... /assign @jimmidyson |
I signed it |
deploy/minikube/k8s_releases.json
Outdated
@@ -101,4 +104,4 @@ | |||
{ | |||
"version": "v1.3.0" | |||
} | |||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you add the newline back?
@minikube-bot OK to test |
Hmm - not sure how the version bump broke this
Above is the last failures I saw from the log on |
Just saw
the actual error, I guess, is ..
on line 219 though that's just out of order, the above errors happen before this one. Hope that helps somehow? |
@alex-leonhardt : you don't have to update Most likely, that file should be deleted now. But the about socat/crictl errors are weird. |
Hmm, Promoting Unfortunately this is mostly* undocumented for anything but Container Linux:
It is normally downloaded from https://github.com/kubernetes-sigs/cri-tools |
Is there anything I can do, or do we need to wait for #3150 to be completed? |
@alex-leonhardt : probably better to move to |
I think that we have still some issue related to |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: alex-leonhardt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ok, so now it's "too old" and has a conflict in |
The basic idea (upgrade the kubernetes version) is still valid, even though the Pull Request wasn't. @tstromberg : something to consider for the next release, perhaps ? ( |
@alex-leonhardt : |
Enables v1.11.0 and sets it to be the default version.