-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow certificates to be optionally embedded in .kube/config #3065
Conversation
Opt-in with `minikube config set embed-certs true`. Similar to the behaviour of `kubectl config set-credentials --embed-certs`. Enables Minikube on Windows to produce a .kube/config file that can be shared directly with kubectl inside the Windows Subsystem for Linux (WSL) without needing to perform additional translation of the certificate paths within the configuration file.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jstangroome If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
While I'd love to see embedded certificates in the |
/assign @dlorenc |
@minikube-bot OK to test |
I could really use this.. @neolit123 any thoughts? How come this patch got "stuck"? |
@jstangroome with your changes at present, does this make .kube/config portable i.e. without a .minkube directory and separate files? |
@alexellis AFAIK, for running kubectl commands, my change means you only need the |
That'd be perfect for my use-case. What is blocking this PR? |
maybe the minikube maintainers can answer that. |
Opt-in with
minikube config set embed-certs true
. Similar to thebehaviour of
kubectl config set-credentials --embed-certs
.Enables Minikube on Windows to produce a .kube/config file that
can be shared directly with kubectl inside the Windows Subsystem
for Linux (WSL) without needing to perform additional translation
of the certificate paths within the configuration file.
Fixes #3064