Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove localkube #2736

Closed
wants to merge 3 commits into from
Closed

[WIP] Remove localkube #2736

wants to merge 3 commits into from

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Apr 17, 2018 •
edited
Loading

  • Remove localkube code
  • Remove vendor

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r2d4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2018
@afbjorklund
Copy link
Collaborator

Currently removing localkube means not being able to run on travis: #2704

This is due to kubeadm requiring systemd, and ubuntu trusty not having it...

See travis-ci/travis-ci#5821 about xenial support

The workaround would be to continue running older versions of minikube

@r2d4
Copy link
Contributor Author

r2d4 commented Apr 20, 2018

Thats true. The systemd requirement is also not a hard requirement, we can run kubeadm without it, but haven't done the work yet.

@dlorenc
Copy link
Contributor

dlorenc commented Apr 30, 2018

@minikube-bot test this please

@bialad
Copy link

bialad commented May 3, 2018

I'm working on using localkube for running a small single node deployment. What's the reasoning around removing localkube? Is anything replacing it?

@commitay commitay mentioned this pull request May 9, 2018
Closed
4 tasks
@r2d4 r2d4 closed this May 24, 2018
@r2d4 r2d4 deleted the remove-localkube branch May 24, 2018 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@r2d4 @k8s-ci-robot @afbjorklund @dlorenc @bialad