Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-machine for hyper-v fix. #2719

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Update docker-machine for hyper-v fix. #2719

merged 1 commit into from
Apr 12, 2018

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Apr 12, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 12, 2018
@dlorenc
Copy link
Contributor Author

dlorenc commented Apr 12, 2018

Ref #2700

@gbraad I think this should be the same as your fix, but includes the godep change so we won't stomp over it next time.

@dlorenc dlorenc merged commit 85cac4d into kubernetes:master Apr 12, 2018
@dlorenc dlorenc deleted the fixmachine branch April 12, 2018 20:59
@dlorenc dlorenc mentioned this pull request Apr 12, 2018
Closed
@gbraad
Copy link
Contributor

gbraad commented Apr 12, 2018

Thanks!

@gbraad
Copy link
Contributor

gbraad commented Apr 13, 2018

Will there be a point release? It is currently breaking for the majority of HyperV users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r2d4 r2d4 r2d4 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlorenc @k8s-ci-robot @gbraad @r2d4