Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx-ingress version to 0.12.0 #2644

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Update nginx-ingress version to 0.12.0 #2644

merged 1 commit into from
Mar 27, 2018

Conversation

oilbeater
Copy link
Contributor

The new version resolve some rewrite, session-affinity and templates bugs and will fix #2206

I see couples of ingress issues in minikube issue list, some of them are related to nginx-ingress itself, maybe this issue can be opened in nginx-ingress issue list to get a quick response

The new version resolve some rewrite, session-affinity and templates bugs and will fix #2206
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oilbeater
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

Assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dlorenc
Copy link
Contributor

dlorenc commented Mar 26, 2018

@minikube-bot ok to test

@dlorenc
Copy link
Contributor

dlorenc commented Mar 27, 2018

LGTM. The build slaves are having a few issues right now.

@dlorenc dlorenc merged commit fe88166 into kubernetes:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingress session affinity cookies not set
4 participants