Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend hyper-v module name to fix cmdlet collision with vmware powercli #2577

Closed

Conversation

davemay99
Copy link

Fixes #2226

When VMware PowerCLI is installed alongside Hyper-V, there are multiple command collisions which prevent the hyperv Docker machine driver from working as expected. I fixed the underlying Docker Machine issue in docker/machine#4404 by prepending the hyper-v module name to ensure the correct module is used.

This pull request contains the latest hyperv machine driver code from the Docker Machine repo, which also includes code to help select the correct V-Switch if one is not specified.

Signed-off-by: Dave May dave.may@tresta.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davemay99
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jimmidyson

Assign the PR to them by writing /assign @jimmidyson in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2018
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@davemay99
Copy link
Author

/assign @jimmidyson

@jimmidyson
Copy link
Member

Looks good, but Godeps/Godeps.json needs updating too I think.

@davemay99
Copy link
Author

@jimmidyson I'm not familiar with the update procedure for Godeps.json.

It doesn't appear that Comment is still relevant and/or updated. So if my fix was committed into docker/machine at docker/machine@15095c9, and I only changed files related to the hyperv driver, do I just need to update the Rev as follows?

                {
                        "ImportPath": "github.com/docker/machine/drivers/hyperv",
                        "Comment": "docs-v0.8.2-2016-09-26-292-g49dfaa70",
                        "Rev": "15095c90d0f546419628df8eccd68c99cc2067f4"
                },

@dlorenc
Copy link
Contributor

dlorenc commented Mar 1, 2018

We have some documentation here on the right way to update godeps: https://github.com/kubernetes/minikube/blob/master/docs/contributors/adding_a_dependency.md

It's a bit of a pain, so if you want I can make the change for you.

@davemay99
Copy link
Author

@dlorenc I would certainly appreciate it if you could handle the godeps issue on this update! I'd love to tackle updating godeps next time, but was hoping to get the underlying issue resolved quickly.

@dlorenc
Copy link
Contributor

dlorenc commented Mar 6, 2018

Closing in favor of #2586

@dlorenc dlorenc closed this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to start minikube for hyperv if vmware module is present
5 participants