Create ServiceAccount and ClusterRoleBinding for storage-provisioner #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: colinhoglund Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-ci-robot
added
the
size/S
|
Can one of the admins verify this patch? |
k8s-ci-robot
added
size/M
|
I believe this resolves or at least partially addresses the following: |
|
@minikube-bot ok to test |
r2d4
approved these changes
Jan 29, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gets the storage-provisioner working when RBAC is enabled by utilizing the
system:persistent-volume-provisionerClusterRole as outlined here. I have verified this continues to work with RBAC disabled.I am also adding
storage-provisionerto config settings, and settingaddonmanager.kubernetes.io/mode: Reconcileon the Pod, so that it can be disabled by the addon-manager.