Skip to content

test: Fix TestMiniPath unit test on windows #21739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

test: Fix TestMiniPath unit test on windows #21739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b7071e
Fixed TestMiniPath unit test failure in windows
bobsira Oct 13, 2025
d6a70e0
localpath: early normalize MINIKUBE_HOME in MiniPath
bobsira Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions pkg/minikube/localpath/localpath.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ func ConfigFile() string {
func MiniPath() string {
minikubeHomeEnv := os.Getenv(MinikubeHome)
if minikubeHomeEnv == "" {
return filepath.Join(homedir.HomeDir(), ".minikube")
return filepath.Join(filepath.Clean(homedir.HomeDir()), ".minikube")
}
if filepath.Base(minikubeHomeEnv) == ".minikube" {
return minikubeHomeEnv

norm := filepath.Clean(minikubeHomeEnv)

if filepath.Base(norm) == ".minikube" {
return norm
}
return filepath.Join(minikubeHomeEnv, ".minikube")
return filepath.Join(norm, ".minikube")
}

// MakeMiniPath is a utility to calculate a relative path to our directory.
Expand Down