Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s 1.8 #2060

Merged
merged 3 commits into from
Oct 16, 2017
Merged

K8s 1.8 #2060

merged 3 commits into from
Oct 16, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Oct 12, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2017
@r2d4
Copy link
Contributor Author

r2d4 commented Oct 13, 2017

@minikube-bot retest this please

@codecov-io
Copy link

codecov-io commented Oct 13, 2017

Codecov Report

Merging #2060 into master will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
+ Coverage   28.59%   28.62%   +0.03%     
==========================================
  Files          80       80              
  Lines        5243     5243              
==========================================
+ Hits         1499     1501       +2     
+ Misses       3551     3550       -1     
+ Partials      193      192       -1
Impacted Files Coverage Δ
cmd/minikube/cmd/service_list.go 10.34% <ø> (ø) ⬆️
pkg/minikube/service/service.go 29.76% <ø> (ø) ⬆️
pkg/minikube/bootstrapper/kubeadm/util.go 0% <ø> (ø) ⬆️
pkg/util/kubernetes.go 0% <0%> (ø) ⬆️
pkg/localkube/storage_provisioner.go 0% <0%> (ø) ⬆️
pkg/localkube/kubelet.go 0% <0%> (ø) ⬆️
pkg/util/kubeconfig/config.go 48.29% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c28c583...9dbd396. Read the comment docs.

@maciaszczykm
Copy link
Member

@r2d4 Hi, at Kubernetes Dashboard we have started using minikube for our integration tests. We are in the process of migration to 1.8 and adding new resources like Cron Jobs, so it would be extremely useful for us to be able to run 1.8 on Travis. Do you have any timeframe for it? You can check our minikube startup script at: https://github.com/kubernetes/dashboard/blob/master/build/minikube.sh.

@dlorenc
Copy link
Contributor

dlorenc commented Oct 16, 2017

@minikube-bot test this please

@dlorenc
Copy link
Contributor

dlorenc commented Oct 16, 2017

@maciaszczykm hopefully in the next day or so.

@r2d4
Copy link
Contributor Author

r2d4 commented Oct 16, 2017

@dlorenc PTAL

@maciaszczykm
Copy link
Member

@dlorenc Super, thanks!

@r2d4 r2d4 merged commit 6a53c0c into kubernetes:master Oct 16, 2017
@r2d4 r2d4 deleted the k8s18 branch October 16, 2017 20:11
@maciaszczykm
Copy link
Member

@maciaszczykm hopefully in the next day or so.

@dlorenc Just to clarify, does that mean the new release is coming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants