-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross build debug and split drivers #2033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2033 +/- ##
==========================================
+ Coverage 28.59% 28.62% +0.03%
==========================================
Files 80 80
Lines 5243 5243
==========================================
+ Hits 1499 1501 +2
+ Misses 3551 3550 -1
+ Partials 193 192 -1
Continue to review full report at Codecov.
|
Results from the first run
|
Clearly, the cross build shouldn't take an hour. I'm going to add a commit that splits these up to see which binary is taking the majority of the time. |
Second run - looks like localkube is the culprit
|
Running the makefile rules in parallel gives us about a 14-15x speedup Well in my unscientific benchmark, I tested j=8,16,32
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice!
This will help us figure out why the cross builds suddenly are taking so long
Also fixes #2030 by splitting out the drivers from the cross rule