Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use virtualbox on windows for integration tests #2024

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

r2d4
Copy link
Contributor

@r2d4 r2d4 commented Oct 2, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2017
@codecov-io
Copy link

codecov-io commented Oct 2, 2017

Codecov Report

Merging #2024 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2024      +/-   ##
==========================================
+ Coverage    29.6%   29.69%   +0.09%     
==========================================
  Files          77       77              
  Lines        4810     4842      +32     
==========================================
+ Hits         1424     1438      +14     
- Misses       3204     3218      +14     
- Partials      182      186       +4
Impacted Files Coverage Δ
pkg/minikube/machine/cache_images.go 10.05% <0%> (+7.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda5abd...cae751a. Read the comment docs.

@gbraad
Copy link
Contributor

gbraad commented Oct 3, 2017

What are actually the issues on Windows with HyperV?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 3, 2017
@r2d4 r2d4 merged commit 93323c6 into kubernetes:master Oct 3, 2017
@r2d4 r2d4 deleted the windows-vbox branch October 3, 2017 21:34
@r2d4
Copy link
Contributor Author

r2d4 commented Oct 3, 2017

@gbraad We've had a lot of trouble automating the creation and the continued use of the virtual switches. Before this, we weren't actually running any windows CI tests for awhile, since the physical machine we test on was totally broken.

I fixed it up, but I don't really have a ton of cycles to maintain it, so we're just switching this over the virtualbox, which doesn't have the complexity of the virtual switches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants