Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove repeated pkg and cmdUtil -> cmdutil #2010

Merged
merged 1 commit into from
Sep 27, 2017
Merged

remove repeated pkg and cmdUtil -> cmdutil #2010

merged 1 commit into from
Sep 27, 2017

Conversation

alwqx
Copy link
Contributor

@alwqx alwqx commented Sep 27, 2017

  • remove repeated pkg "k8s.io/minikube/pkg/util"
  • cmdUtil -> cmdutil to be in conformity with pkgutil "k8s.io/minikube/pkg/util"

Signed-off-by: adolphlwq kenan3015@gmail.com

Signed-off-by: adolphlwq <kenan3015@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #2010 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2010   +/-   ##
=======================================
  Coverage   29.87%   29.87%           
=======================================
  Files          77       77           
  Lines        4760     4760           
=======================================
  Hits         1422     1422           
  Misses       3158     3158           
  Partials      180      180
Impacted Files Coverage Δ
cmd/minikube/cmd/start.go 9.93% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 023aea1...6d64d90. Read the comment docs.

@dlorenc
Copy link
Contributor

dlorenc commented Sep 27, 2017

@minikube-bot OK to test

Copy link
Contributor

@r2d4 r2d4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@r2d4 r2d4 merged commit 9d0c80d into kubernetes:master Sep 27, 2017
@alwqx alwqx deleted the remove-repeated-pkg branch September 28, 2017 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants