Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added localkube devshell container tests to jenkins #1999

Merged
merged 1 commit into from
Sep 29, 2017
Merged

added localkube devshell container tests to jenkins #1999

merged 1 commit into from
Sep 29, 2017

Conversation

aaron-prindle
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 23, 2017
@aaron-prindle aaron-prindle force-pushed the container-tests branch 4 times, most recently from 7219c7f to 109dfaa Compare September 25, 2017 21:28
r2d4
r2d4 approved these changes Sep 25, 2017
View reviewed changes
hack/jenkins/linux_integration_tests_devshell.sh Outdated

docker stop devshell
docker rm devshell
exit $RET
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hack/jenkins/linux_integration_tests_devshell.sh Outdated

RET=0

docker run --name devshell -p 127.0.0.1:8080:4321 --privileged gcr.io/k8s-minikube/localkube-dind-image-devshell:$COMMIT /start.sh &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice-to-have here would be to let docker use a random name and port so we can run these tests in parallel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

hack/jenkins/linux_integration_tests_devshell.sh Outdated
@@ -0,0 +1,50 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to add this job to the "set-pending" script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@aaron-prindle aaron-prindle force-pushed the container-tests branch 4 times, most recently from 32e52cd to 7772ed2 Compare September 26, 2017 22:27
dlorenc
dlorenc reviewed Sep 27, 2017
View reviewed changes
hack/jenkins/linux_integration_tests_container.sh Outdated
result=0
JOB_NAME="Linux-Container"

NAME=devshell-"$(cat /dev/urandom | tr -cd 'a-f0-9' | head -c 32)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to use the --name parameter, it might be a bit more robust to grab the generated container id like:

cid=$(docker run -d ...) and avoid passing in --name everywhere.

hack/jenkins/minikube_cross_build_and_upload.sh Outdated

# Upload containers for the PR:
make localkube-image
gcloud docker -- push gcr.io/k8s-minikube/localkube-image:$ghprbActualCommit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tag we use is based on the localkube version, not on the commit ID:
https://github.com/kubernetes/minikube/blob/master/Makefile#L45

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am planning on using a COMMIT based tag for the jenkins CI testing and a LOCALKUBE_VERSION tag for releases. When building the image for CI I set the TAG=COMMIT

@aaron-prindle aaron-prindle force-pushed the container-tests branch 8 times, most recently from a5a29f2 to 3e5fc7e Compare September 28, 2017 21:27
@codecov-io
Copy link

codecov-io commented Sep 28, 2017 •
edited
Loading

Codecov Report

Merging #1999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1999   +/-   ##
======================================
  Coverage    29.6%   29.6%           
======================================
  Files          77      77           
  Lines        4810    4810           
======================================
  Hits         1424    1424           
  Misses       3204    3204           
  Partials      182     182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abee78...959720f. Read the comment docs.

@aaron-prindle aaron-prindle merged commit eda5abd into kubernetes:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc left review comments

@r2d4 r2d4 r2d4 approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaron-prindle @codecov-io @r2d4 @dlorenc @k8s-ci-robot