Implement extra-config for kubeadm components #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
Codecov Report
@@ Coverage Diff @@
## master #1985 +/- ##
==========================================
- Coverage 29.69% 28.59% -1.11%
==========================================
Files 77 80 +3
Lines 4842 5243 +401
==========================================
+ Hits 1438 1499 +61
- Misses 3218 3551 +333
- Partials 186 193 +7
Continue to review full report at Codecov.
|
dlorenc
reviewed
Sep 20, 2017
| func NewKubeletConfig(k8s bootstrapper.KubernetesConfig) (string, error) { | ||
| flags := []string{} | ||
| for _, opt := range k8s.ExtraOptions { | ||
| if opt.Component == "kubelet" { |
There was a problem hiding this comment.
maybe make "kubelet" a constant if it's not already one?
| } | ||
| } | ||
| // Strip leading 'v' prefix from version for semver parsing | ||
| fmt.Println(k8s.KubernetesVersion) |
| } | ||
|
|
||
| // versions >= 1.8.0-alpha.0 require the --fail-swap-on flag set to false | ||
| if version.GTE(version18) { |
There was a problem hiding this comment.
yuck, is this because or ISO has swap on? Should we just turn it off?
There was a problem hiding this comment.
Going forward this might be more maintainable if we have a map of special cased flags to versions, but this should be OK for now. Maybe just leave a TODO about that.
r2d4
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
r2d4
force-pushed
the
kubelet-config-kubeadm
branch
from
fe194a6
to
312bec6
Compare
k8s-ci-robot
added
size/XL
|
Updated with:
|
r2d4
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
r2d4
changed the title
r2d4
force-pushed
the
kubelet-config-kubeadm
branch
from
312bec6
to
a139ccd
Compare
|
LGTM |
aaron-prindle
approved these changes
Oct 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all the changes needed to make
minikube start --kubernetes-version=v1.8.0-beta.0 --bootstrapper=kubeadmwork.The kubelet now will respect the extra config options set by minikube's
--extra-configflags.