Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1981 #1982

Merged
merged 2 commits into from
Sep 19, 2017
Merged

Fix issue 1981 #1982

merged 2 commits into from
Sep 19, 2017

Conversation

hirsim
Copy link
Contributor

@hirsim hirsim commented Sep 19, 2017

Fix issue /issues/1981.

Path to the cert file in /var/lib/localkube/kubeconfig on a minikube VM was broken.

apiVersion: v1
clusters:
- cluster:
    certificate-authority: \var\lib\localkube\certs\ca.crt
    server: https://localhost:8443
  name: minikube
contexts:
- context:
    cluster: minikube
    user: minikube
  name: minikube
current-context: minikube
kind: Config
preferences: {}
users:
- name: minikube
  user:
    client-certificate: \var\lib\localkube\certs\apiserver.crt
    client-key: \var\lib\localkube\certs\apiserver.key

Fixed it.

And fixed create location of a image cache folder for Windows.
But, ParseReference does not support Windows drive letter.
If contains Windows drive letter, it disable caching image for now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2017
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@r2d4
Copy link
Contributor

r2d4 commented Sep 19, 2017

@minikube-bot ok to test

@codecov-io
Copy link

Codecov Report

Merging #1982 into master will decrease coverage by 0.12%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
- Coverage      30%   29.87%   -0.13%     
==========================================
  Files          77       77              
  Lines        4740     4760      +20     
==========================================
  Hits         1422     1422              
- Misses       3138     3158      +20     
  Partials      180      180
Impacted Files Coverage Δ
pkg/minikube/machine/cache_images.go 2.18% <0%> (-0.38%) ⬇️
pkg/minikube/bootstrapper/certs.go 85.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c4455...442f746. Read the comment docs.

@r2d4 r2d4 merged commit 93f6eb2 into kubernetes:master Sep 19, 2017
@r2d4
Copy link
Contributor

r2d4 commented Sep 19, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants