Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi-OS Cluster]: Windows Node Support for in Minikube #18650

Closed

Conversation

bobsira
Copy link

@bobsira bobsira commented Apr 16, 2024

No description provided.

Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bobsira
Once this PR has been reviewed and has the lgtm label, please assign prezha for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @bobsira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 16, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@spowelljr
Copy link
Member

spowelljr commented Apr 16, 2024

If you look at https://github.com/kubernetes/minikube/pull/18650/commits you'll see that you can't click on your name, so it looks like the email you committed with doesn't match your GitHub account.

@bobsira
Copy link
Author

bobsira commented Apr 22, 2024

If you look at https://github.com/kubernetes/minikube/pull/18650/commits you'll see that you can't click on your name, so it looks like the email you committed with doesn't match your GitHub account.

Closing this and opening another PR with sbobfitz2@gmail.com email address

@bobsira bobsira closed this Apr 22, 2024
@bobsira
Copy link
Author

bobsira commented Apr 22, 2024

If you look at https://github.com/kubernetes/minikube/pull/18650/commits you'll see that you can't click on your name, so it looks like the email you committed with doesn't match your GitHub account.

Closing this and opening another PR with sbobfitz2@gmail.com email address

New PR: #18707

@bobsira bobsira deleted the user/bosira/en-windows-node-support branch April 22, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants