Site: Disable Beta buttons in "Get started!" documentation if the release is older than the latest Stable release.

[Sryther]

Disabling Beta buttons is not instantaneous. I'm not sure that's the most convenient method to do it.

First it looks for latest release, if it's not a Beta one it'll disable the Beta button and activate the Stable one instead.

fixes #18505

[k8s-ci-robot]

Welcome @Sryther!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Sryther. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[medyagh]

hi @Sryther thanks for the quick PR ! however in the prview I see it is disabled

https://deploy-preview-18514--kubernetes-sigs-minikube.netlify.app/docs/start/

even though right now minikube does have a new beta release, (it should have NOT been grayed out)

see
https://github.com/kubernetes/minikube/releases/tag/v1.33.0-beta.0
which is newer than 1.32

[Sryther]

even though right now minikube does have a new beta release, (it should have NOT been grayed out)

You're totally right, I just forgot to invert the condition while I was testing...

[spowelljr]

Hi @Sryther, thanks for your PR! I took a look at this and think we can simplify this. First off, 99% of the time we don't want to show the Beta button, so I think it's better if we start with it completely hidden and show it if there's a beta available. We have an existing hide class we can use, and for minimal code changes, we can check if option == "Beta" and if it is add the hide class by default (shown below).

diff --git a/site/layouts/shortcodes/quiz_button.html b/site/layouts/shortcodes/quiz_button.html
index 1100d1e92..3cf0b6433 100644
--- a/site/layouts/shortcodes/quiz_button.html
+++ b/site/layouts/shortcodes/quiz_button.html
@@ -1 +1 @@
-<button data-quiz-id="{{ .Parent.Get "base" }}/{{ .Get "option" }}" type="button" class="btn btn-outline-primary option-button">{{ .Get "option" }}</button>
+<button data-quiz-id="{{ .Parent.Get "base" }}/{{ .Get "option" }}" type="button" class="btn btn-outline-primary option-button{{ if eq (.Get "option") "Beta" }} hide{{ end }}">{{ .Get "option" }}</button>

Then this will simplify a lot of your code because you can remove your logic that changes the active button to Stable since the button won't be available if there's no beta, and if there is a beta we simply remove the hide class.

diff --git a/site/content/en/docs/start/_index.md b/site/content/en/docs/start/_index.md
index 71b0a86bc..569f9b0cf 100644
--- a/site/content/en/docs/start/_index.md
+++ b/site/content/en/docs/start/_index.md
@@ -38,21 +38,11 @@ All you need is Docker (or similarly compatible) container or a Virtual Machine
       if (releases && releases.length > 0 && releases[0] && releases[0].tag_name) {
         const isBetaMostRecent = releases[0].tag_name.includes("-beta");
 
-        if (!isBetaMostRecent) {
+        if (isBetaMostRecent) {
           for (architecture of architectures) {
             const betaElement = document.querySelector(`button[data-quiz-id="/${architecture}/Beta"]`);
-            const stableElement = document.querySelector(`button[data-quiz-id="/${architecture}/Stable"]`);
             if (betaElement) {
-              betaElement.disabled = true;
-
-              if (betaElement.classList.contains("active")) {
-                const stableElement = document.querySelector(`button[data-quiz-id="/${architecture}/Stable"]`);
-                if (stableElement) {
-                  stableElement.click();
-                  stableElement.classList.add("active");
-                }
-                betaElement.classList.remove("active");
-              }
+              betaElement.classList.remove("hide");
             }
           }
         }

[Sryther]

I wasn't aware of the .hide class! Your proposal is clearly better with the arguments you're pointing at. Although, I don't think mentioning "Beta" is a good idea in the quizz_button shortcode, I mean a more generic parameter should be used, such as hidden or something like this:

{{% quiz_button option="Beta" hidden="true" %}}

It should work, right?

[spowelljr]

Yeah, that's completely fine, I just used Beta to set hide because this component was specifically created for this so it's unlikely to be used anywhere else and would save from having to manually add hide="true" to all the beta ones. But making it generic is great too

[medyagh]

can we console out log how long this takes, so for reference ? I wanna know if it worth it to make our site slower by this call ..

[Sryther]

I added a timer to measure the performance. Anyway it's asynchronous, it shouldn't affect page loading 🙂 .

[spowelljr]

Thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, Sryther

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment