Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go vet issues #18220

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix go vet issues #18220

merged 1 commit into from
Feb 21, 2024

Conversation

spowelljr
Copy link
Member 

$ go vet ./...
# k8s.io/minikube/third_party/go9p
third_party/go9p/ufs_darwin.go:47:16: io/fs.PathError struct literal uses unkeyed fields
third_party/go9p/ufs_darwin.go:51:16: io/fs.PathError struct literal uses unkeyed fields

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Feb 20, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18220) |
+----------------+----------+---------------------+
| minikube start | 51.4s    | 50.7s               |
| enable ingress | 28.0s    | 26.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 18220) start: 50.6s 51.0s 52.5s 50.7s 49.0s
Times for minikube start: 51.3s 50.4s 53.5s 49.5s 52.1s

Times for minikube ingress: 29.1s 29.1s 27.7s 27.2s 27.1s
Times for minikube (PR 18220) ingress: 25.7s 24.7s 28.1s 28.2s 28.2s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18220) |
+----------------+----------+---------------------+
| minikube start | 24.0s    | 22.9s               |
| enable ingress | 20.7s    | 20.8s               |
+----------------+----------+---------------------+

Times for minikube start: 24.5s 24.5s 25.2s 23.8s 22.0s
Times for minikube (PR 18220) start: 25.3s 21.0s 22.1s 21.1s 24.8s

Times for minikube ingress: 20.8s 20.9s 20.9s 20.3s 20.8s
Times for minikube (PR 18220) ingress: 21.8s 21.8s 18.8s 20.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18220) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.4s               |
| enable ingress | 30.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube ingress: 31.3s 31.3s 30.3s 30.3s 30.3s
Times for minikube (PR 18220) ingress: 33.3s 30.3s 31.3s 31.3s 31.3s

Times for minikube start: 23.0s 20.7s 23.2s 20.5s 20.6s
Times for minikube (PR 18220) start: 20.5s 20.7s 22.6s 23.0s 20.4s

@medyagh medyagh merged commit 7041fb9 into kubernetes:master Feb 21, 2024
35 of 50 checks passed
@spowelljr spowelljr deleted the fixGoVet branch February 21, 2024 03:54
@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
QEMU_macOS TestMountStart/serial/VerifyMountPostDelete (gopogh) n/a
Hyper-V_Windows TestOffline (gopogh) 0.00 (chart)
Docker_Linux_docker_arm64 TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestKubernetesUpgrade (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 1.25 (chart)
Docker_Linux_docker_arm64 TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 1.25 (chart)
Docker_Linux TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 1.25 (chart)
Docker_Linux TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 1.25 (chart)
Docker_Linux TestKubernetesUpgrade (gopogh) 1.25 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 1.25 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 1.25 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 1.25 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 1.25 (chart)
Docker_Linux TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 1.25 (chart)
Docker_Windows TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 3.23 (chart)
Docker_Windows TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 3.23 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 3.23 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 3.23 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 3.23 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 3.23 (chart)
Docker_Windows TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 3.23 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 6.45 (chart)
Hyper-V_Windows TestMultiNode/serial/DeleteNode (gopogh) 41.18 (chart)

To see the flake rates of all tests by environment, click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spowelljr @k8s-ci-robot @medyagh @minikube-pr-bot